only list baremetal nodes once

Author: sjpb

environments/skeleton/{{cookiecutter.environment}}/terraform/compute.tf

@@ -18,4 +18,5 @@ module "compute" {
   k3s_token = var.k3s_token
   k3s_server = [for n in openstack_compute_instance_v2.control["control"].network: n.fixed_ip_v4 if n.access_network][0]
   security_group_ids = [for o in data.openstack_networking_secgroup_v2.nonlogin: o.id]
+  baremetal_nodes = data.external.baremetal_nodes.result
 }

environments/skeleton/{{cookiecutter.environment}}/terraform/compute/nodes.tf

@@ -1,11 +1,3 @@
-data "external" "nodes" {
-  program = ["bash", "-c", <<-EOT
-    openstack baremetal node list --limit 0 -f json 2>/dev/null | \
-    jq -r 'try map( { (.Name|tostring): .UUID } ) | add catch {}' || echo '{}'
-  EOT
-  ]
-}
-
 resource "openstack_networking_port_v2" "compute" {
 
   for_each = toset(var.nodes)
@@ -58,7 +50,7 @@ resource "openstack_compute_instance_v2" "compute" {
     k3s_server = var.k3s_server
   }
 
-  availability_zone = var.match_ironic_node ? "${var.availability_zone}::${data.external.nodes.result[each.key]}" : var.availability_zone
+  availability_zone = var.match_ironic_node ? "${var.availability_zone}::${var.baremetal_nodes[each.key]}" : var.availability_zone
 
   user_data = <<-EOF
     #cloud-config

environments/skeleton/{{cookiecutter.environment}}/terraform/compute/variables.tf

@@ -89,3 +89,7 @@ variable availability_zone {
     type = string
     default = "nova"
 }
+
+variable "baremetal_nodes" {
+    type = map(string)
+}

environments/skeleton/{{cookiecutter.environment}}/terraform/nodes.tf

@@ -12,7 +12,7 @@ locals {
   }
 }
 
-data "external" "nodes" {
+data "external" "baremetal_nodes" {
   # returns an empty map if cannot list baremetal nodes
   program = ["bash", "-c", <<-EOT
     openstack baremetal node list --limit 0 -f json 2>/dev/null | \
@@ -148,7 +148,7 @@ resource "openstack_compute_instance_v2" "login" {
     k3s_server = [for n in openstack_compute_instance_v2.control["control"].network: n.fixed_ip_v4 if n.access_network][0]
   }
 
-  availability_zone = each.value.match_ironic_node ? "${each.value.availability_zone}::${data.external.nodes.result[each.key]}" : each.value.availability_zone
+  availability_zone = each.value.match_ironic_node ? "${each.value.availability_zone}::${data.external.baremetal_nodes.result[each.key]}" : each.value.availability_zone
 
   user_data = <<-EOF
     #cloud-config