fix nhc mid-upgrade

Author: sjpb

ansible/roles/nhc/tasks/boot.yml

@@ -1,11 +1,3 @@
-- name: Ensure NHC configuration directory exists
-  ansible.builtin.file:
-    path: /etc/nhc
-    state: directory
-    owner: root
-    group: root
-    mode: u=rwX,go= # HealthCheckProgram is run by root
-
 - name: Copy stored NHC configuration to active location
   ansible.builtin.copy:
     remote_src: true

ansible/roles/nhc/tasks/main.yml

@@ -1,16 +1,20 @@
 
 - name: Ensure NHC configuration directory exists
+  # When running site.yml after login/control upgrade, nhc group might be
+  # enabled in repo, but as the compute nodes have not yet been upgraded they
+  # do not have the package and hence this directory
   ansible.builtin.file:
     path: /etc/nhc
     state: directory
+    # to match nhc-ohpc install:
     owner: root
     group: root
-    mode: u=rwX,go= # HealthCheckProgram is run by root
+    mode: u=rwX,go=
 
 - name: Template out NHC configuration
   ansible.builtin.template:
     src: "{{ nhc_config_template }}"
     dest: /etc/nhc/nhc.conf
     owner: root
     group: root
-    mode: u=rw,go=
+    mode: u=rw,go= # HealthChecProgram is run by root