Fix linting issues on the merge of origin/main

Author: maxstack

ansible/extras.yml

@@ -52,16 +52,16 @@
 
 - name: Setup vGPU
   hosts: vgpu
-  become: yes
-  gather_facts: yes
+  become: true
+  gather_facts: true
   tags: vgpu
   tasks:
-    - include_role:
+    - ansible.builtin.include_role:
         name: stackhpc.linux.vgpu
         tasks_from: "{{ 'configure.yml' if appliances_mode == 'configure' else 'install.yml' }}"
   handlers:
-    - name: reboot
-      fail:
+    - name: reboot # noqa: name[casing]
+      ansible.builtin.fail:
         msg: Reboot handler for stackhpc.linux.vgpu role fired unexpectedly. This was supposed to be unreachable.
 
 - name: Persist hostkeys across rebuilds

ansible/fatimage.yml

@@ -179,7 +179,7 @@
         name: ondemand_exporter
       when: "'openondemand' in group_names"
 
-    - name: slurm exporter
+    - name: Slurm exporter
       ansible.builtin.include_role:
         name: slurm_exporter
         tasks_from: install.yml
@@ -258,18 +258,18 @@
     - ansible.builtin.import_role:
         name: cloudalchemy.grafana
         tasks_from: install.yml
-    - import_role:
+    - ansible.builtin.import_role:
         name: cloudalchemy.grafana
         tasks_from: plugins.yml
-    - include_role: # done in same play so it can use handlers from cloudalchemy.grafana
+    - ansible.builtin.include_role: # done in same play so it can use handlers from cloudalchemy.grafana
         name: grafana-dashboards
 
 - name: Add support for NVIDIA GPU auto detection to Slurm
   hosts: cuda
-  become: yes
+  become: true
   tasks:
     - name: Recompile slurm
-      import_role:
+      ansible.builtin.import_role:
         name: slurm_recompile
       vars:
         slurm_recompile_with_nvml: "{{ groups.cuda | length > 0 }}"

ansible/final.yml

@@ -1,5 +1,5 @@
 - hosts: dnf_repos
-  become: yes
+  become: true
   tags: dnf_repos
   tasks:
     - name: Disable pulp repos
@@ -12,19 +12,19 @@
   hosts: compute_init:!builder
   # NB: done last so other roles can prepare configuration etc
   tags: compute_init
-  become: yes
+  become: true
   tasks:
-    - include_role:
+    - ansible.builtin.include_role:
         name: compute_init
         tasks_from: export.yml
 
 - hosts: proxy
   gather_facts: false
   tags: proxy
-  become: yes
+  become: true
   tasks:
-    - include_role:
+    - ansible.builtin.include_role:
         name: proxy
       vars:
         proxy_state: absent
-      when: proxy_remove | default(false) | bool == true
+      when: proxy_remove | default(false) | bool

ansible/monitoring.yml

@@ -71,7 +71,7 @@
     - name: Skip prometheus install if prometheus binaries exist and prometheus_version not defined
       # i.e. if prometheus_version isn't defined we don't care, so use what's already there
       ansible.builtin.set_fact:
-        prometheus_skip_install: "{{ false if prometheus_version is defined else true }}" 
+        prometheus_skip_install: "{{ false if prometheus_version is defined else true }}"
       when: "(prometheus_binaries.results | map(attribute='stat') | map(attribute='exists')) + [prometheus_skip_install is not defined]"
     - ansible.builtin.import_role:
         name: cloudalchemy.prometheus

ansible/roles/compute_init/README.md

@@ -54,7 +54,7 @@ it also requires an image build with the role name added to the
 | bootstrap.yml            | dnf_repos                     | None at present [2]             | -                   |
 | bootstrap.yml            | cacerts                       | Supported [3]                   | -                   |
 | bootstrap.yml            | squid                         | Not relevant for compute nodes  | n/a                 |
-| bootstrap.yml            | tuned                         | Fully supported                 | No                  |         
+| bootstrap.yml            | tuned                         | Fully supported                 | No                  |
 | bootstrap.yml            | freeipa_server                | Not relevant for compute nodes  | n/a                 |
 | bootstrap.yml            | cockpit                       | None required - use image build | No                  |
 | bootstrap.yml            | firewalld                     | Not relevant for compute nodes  | n/a                 |
@@ -91,7 +91,7 @@ it also requires an image build with the role name added to the
 | portal.yml               | (openondemand vnc desktop)    | None required - use image build | No                  |
 | portal.yml               | (openondemand jupyter server) | None required - use image build | No                  |
 | monitoring.yml           | node_exporter                 | None required - use image build | No                  |
-| monitoring.yml           | (other  monitoring)           | Not relevant for compute nodes  | -                   |
+| monitoring.yml           | (other monitoring)            | Not relevant for compute nodes  | -                   |
 | disable-repos.yml        | dnf_repos                     | None at present [2]             | -                   |
 | hooks/post.yml           | ?                             | None at present                 | -                   |
 

ansible/roles/compute_init/files/compute-init.yml

@@ -297,7 +297,6 @@
         - name: Ensure CVMFS config is setup # noqa: no-changed-when
           ansible.builtin.command:
             cmd: "cvmfs_config setup"
-      when: enable_eessi
 
     - name: Configure VGPUs
       ansible.builtin.include_role:
@@ -366,7 +365,7 @@
         tasks_from: boot.yml
       when: enable_nhc
 
-    - name: Ensure node is resumed
+    - name: Ensure node is resumed # noqa: no-changed-when
       # TODO: consider if this is always safe for all job states?
       ansible.builtin.command: scontrol update state=resume nodename={{ ansible_hostname }}
       register: _scontrol_update

ansible/roles/compute_init/tasks/export.yml

@@ -101,7 +101,7 @@
   when: "'sshd' in group_names"
 
 - name: Export generated NHC config
-  import_role:
+  ansible.builtin.import_role:
     name: nhc
     tasks_from: export.yml
   when: "'nhc' in group_names"

ansible/roles/cuda/tasks/facts.yml

@@ -1,4 +1,4 @@
 ---
 - name: Set cuda_facts_version_short
-  set_fact:
+  ansible.builtin.set_fact:
     cuda_facts_version_short: "{{ cuda_version_short }}"

ansible/roles/dnf_repos/tasks/disable_repos.yml

@@ -28,5 +28,5 @@
     path: "{{ item.path }}"
     regexp: '^enabled\ ?=\ ?1'
     replace: 'enabled=0'
-    backup: yes
+    backup: true
   loop: "{{ _dnf_repo_files.files }}"

ansible/roles/doca/defaults/main.yml

@@ -1,4 +1,5 @@
 ---
-doca_version:"2.9.3" # 2.9 is LTS, last to support ConnectX-4, 3 years for bug fixes and CVE updates
+
+doca_version: "2.9.3" # 2.9 is LTS, last to support ConnectX-4, 3 years for bug fixes and CVE updates
 doca_profile: doca-ofed
 doca_repo_url: "https://linux.mellanox.com/public/repo/doca/{{ doca_version }}/rhel{{ ansible_distribution_version }}/{{ ansible_architecture }}/"