Skip to content

Disable compute-init by default & warn of security issue #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 19, 2025
Merged

Disable compute-init by default & warn of security issue #585

merged 5 commits into from
Feb 19, 2025

Conversation

@sjpb
Copy link
Collaborator

@sjpb sjpb commented Feb 18, 2025 •
edited
Loading

  • Removes compute_init role from everything template, so it requires a manual opt-in
  • Warns of security risk due to nfs export of secrets
  • Fixes stackhpc CI (which still tests it)

@sjpb sjpb requested a review from sd109 February 18, 2025 11:08
sd109
sd109 previously approved these changes Feb 18, 2025
View reviewed changes
sd109
sd109 reviewed Feb 18, 2025
View reviewed changes
@sjpb sjpb requested a review from sd109 February 18, 2025 11:42
@sjpb sjpb marked this pull request as ready for review February 18, 2025 11:54
@sjpb sjpb requested a review from a team as a code owner February 18, 2025 11:54
sd109
sd109 previously approved these changes Feb 18, 2025
View reviewed changes
@sjpb sjpb requested a review from sd109 February 19, 2025 11:07
@sjpb sjpb merged commit d474a4f into main Feb 19, 2025
2 checks passed
@sjpb sjpb deleted the fix/compute-init-unsafe-nfs branch February 19, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sd109 sd109 sd109 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjpb @sd109