Skip to content

Allow empty items in extra package and user lists #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Allow empty items in extra package and user lists #637

merged 1 commit into from
Apr 25, 2025

Conversation

priteau
Copy link
Member

@priteau priteau commented Apr 1, 2025

This enables defining extra packages and users based on some conditions. For example:

appliances_extra_packages_other:
  - "{{ 'cuda-toolkit' if 'cuda' in group_names }}"

@priteau priteau self-assigned this Apr 1, 2025
@priteau priteau requested a review from a team as a code owner April 1, 2025 11:34
@priteau
Allow empty items in extra package and user lists
b66fefa 
This enables defining extra packages and users based on some conditions,
for example:

    appliances_extra_packages_other:
      - "{{ 'cuda-toolkit' if 'cuda' in group_names }}"
@sjpb
Copy link
Collaborator

sjpb commented Apr 25, 2025

Normally we'd just do this via some indirection:

appliances_extra_packages_cuda:
  - 'cuda-toolkit'
appliances_extra_packages_other: "{{ if appliances_extra_packages_cuda 'cuda' in group_names else [] }}"

but seems fine.

sjpb
sjpb approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested logic locally and the select | list is enough to ditch the empty string you get.

@priteau
Copy link
Member Author

priteau commented Apr 25, 2025

Normally we'd just do this via some indirection:

appliances_extra_packages_cuda:
  - 'cuda-toolkit'
appliances_extra_packages_other: "{{ if appliances_extra_packages_cuda 'cuda' in group_names else [] }}"

but seems fine.

It is feasible with other methods, but with this approach we don't need to define additional variables.

@priteau priteau merged commit 4ef0c82 into main Apr 25, 2025
2 checks passed
@priteau priteau deleted the extra-list branch April 25, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees

@priteau priteau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priteau @sjpb