Make home volume creation optional #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpb
force-pushed
the
feat/optional-home-vol-v2
branch
from
25f2783 to
40eb623
Compare
sjpb
force-pushed
the
feat/optional-home-vol-v2
branch
from
d82905c to
d810bba
Compare
sjpb
force-pushed
the
feat/optional-home-vol-v2
branch
from
d810bba to
bd891e0
Compare
wtripp180901
requested changes
May 20, 2025
Contributor
wtripp180901
left a comment
wtripp180901
left a comment
There was a problem hiding this comment.
Looks good, docs just need updating
sjpb
force-pushed
the
feat/optional-home-vol-v2
branch
from
0e48cc8 to
ae123b1
Compare
Collaborator
Author
|
Tested state volume is correctly attached both with manage and with attach. Also tested migration route described in production docs for existing clusters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
home_volume_provisioningandstate_volume_provisioningto support production cluster configurations. See docs/production.md.nfs_configurations_extrato make it easier to add site-specific NFS shares.