From 464bd06d89599130188af822d607c67b90b641f6 Mon Sep 17 00:00:00 2001
From: Steve Brasier <steveb@stackhpc.com>
Date: Thu, 7 Aug 2025 12:00:04 +0000
Subject: [PATCH] don't set topology plugin if topology not enabled

---
 .../common/inventory/group_vars/all/openhpc.yml     | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/environments/common/inventory/group_vars/all/openhpc.yml b/environments/common/inventory/group_vars/all/openhpc.yml
index d3af25bac..b3ead1845 100644
--- a/environments/common/inventory/group_vars/all/openhpc.yml
+++ b/environments/common/inventory/group_vars/all/openhpc.yml
@@ -51,31 +51,36 @@ openhpc_state_save_location: "{{ appliances_state_dir + '/slurmctld' if applianc
 # NB: override in environments/site/inventory/group_vars/all/openhpc.yml, not here:
 openhpc_config_extra: {}
 
-# default additional slurm.conf parameters for the appliance:
+# additional default slurm.conf parameters for the appliance:
 openhpc_config_default:
   TaskPlugin: task/cgroup,task/affinity
   ReturnToService: 2 # workaround for templating bug TODO: Remove once on stackhpc.openhpc v1.2.0
-  TopologyPlugin: "topology/{{ 'tree' if (topology_nodes | length) > 0 else 'flat' }}"
 
-# default additional slurm.conf parameters when "rebuild" enabled:
+# additional default slurm.conf parameters when "rebuild" enabled:
 openhpc_config_rebuild:
   RebootProgram: /opt/slurm-tools/bin/slurm-openstack-rebuild
   SlurmctldParameters:
     - reboot_from_controller
   ResumeTimeout: 300
 
-# default additional slurm.conf parameters when "nhc" enabled:
+# additional default slurm.conf parameters when "nhc" enabled:
 openhpc_config_nhc:
   HealthCheckProgram: /usr/sbin/nhc
   HealthCheckInterval: 300
   HealthCheckNodeState: NONDRAINED_IDLE
 
+# additional default slurm.conf parameters when "topology" enabled:
+openhpc_config_topology:
+  TopologyPlugin: topology/tree
+
 # indirection to allow automatic construction of slurm.conf parameters:
 openhpc_config_groups:
   - enabled: "{{ groups['rebuild'] | length > 0 }}"
     config: "{{ openhpc_config_rebuild }}"
   - enabled: "{{ groups['nhc'] | length > 0 }}"
     config: "{{ openhpc_config_nhc }}"
+  - enabled: "{{ groups['topology'] | length > 0 }}"
+    config: "{{ openhpc_config_topology }}"
   - enabled: true
     config: "{{ openhpc_config_extra }}"