Skip to content

Commit e676a70

Browse files
authored
Merge pull request #55 from stackhpc/fix/e2e-test
Fix end-to-end chart test template
2 parents 1d8b9ac + 15af623 commit e676a70

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.github/workflows/test-pr.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ jobs:
4646
- name: Install Helm
4747
uses: azure/setup-helm@v4
4848

49+
- name: Run base chart templating with default values
50+
run: helm template ci-test charts/azimuth-llm
51+
4952
- name: Set up chart testing
5053
uses: helm/chart-testing-action@v2
5154

@@ -62,13 +65,9 @@ jobs:
6265
# we need to pull these published images and load them into the kind cluster
6366
# with the tag correct tag.
6467
- name: Load tagged container images into kind cluster
65-
run: ./kind-images.sh ${{ github.event.pull_request.head.sha }} ${{ env.CLUSTER_NAME }}
68+
run: ./kind-images.sh $(git rev-parse --short ${{ github.event.pull_request.head.sha }}) ${{ env.CLUSTER_NAME }}
6669
working-directory: web-apps
6770

68-
- name: Add Helm repos for dependencies
69-
run: |
70-
helm repo add stakater https://stakater.github.io/stakater-charts
71-
7271
# https://github.com/helm/charts/blob/master/test/README.md#providing-custom-test-values
7372
# Each chart/ci/*-values.yaml file will be treated as a separate test case with it's
7473
# own helm install/test process.

charts/azimuth-llm/templates/test/end-to-end.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ spec:
1010
spec:
1111
containers:
1212
- name: gradio-client-test
13-
image: ghcr.io/stackhpc/azimuth-llm-chat-interface:{{ .Values.ui.image.version }}
13+
{{- /*
14+
Use the chat image since we know this contains the gradio_client package
15+
*/}}
16+
image: {{ printf "ghcr.io/stackhpc/azimuth-llm-chat-ui:%s" (default .Chart.AppVersion .Values.ui.image.tag) }}
1417
imagePullPolicy: IfNotPresent
1518
command:
1619
- python

0 commit comments

Comments
 (0)