Remove CentOS Stream 8 leftovers

And yes, even some CentOS 7 ones

Change-Id: I5df83ec54ecd7b8b363900d7ec7ada1ed9de0f5a

Author: elfosardo

playbooks/roles/bifrost-create-vm-nodes/tasks/main.yml

@@ -41,13 +41,6 @@
     name: "{{ required_packages }}"
     state: present
 
-# NOTE(dtantsur): workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1840485
-- name: "Work around libgrypt issue on RHEL/CentOS 8.3"
-  package:
-    name: libgcrypt
-    state: latest
-  when: ansible_distribution in ['RedHat', 'CentOS']
-
 - name: ensure installation root folder exists
   become: yes
   file:

playbooks/roles/bifrost-ironic-install/defaults/main.yml

@@ -77,14 +77,7 @@ ipa_download_headers: {}
 ipa_kernel: "{{ http_boot_folder }}/ipa.kernel"
 ipa_ramdisk: "{{ http_boot_folder }}/ipa.initramfs"
 ipa_kernel_url: "{{ ipa_file_protocol }}://{{ internal_ip }}:{{ file_url_port }}/ipa.kernel"
-ipa_download_distro: >-
-  {%- if ipa_upstream_release == "stable-train" -%}
-  centos7
-  {%- elif ipa_upstream_release in ["stable-ussuri", "stable-victoria", "stable-wallaby", "stable-xena", "stable-yoga"] -%}
-  centos8
-  {%- else -%}
-  centos9
-  {%- endif -%}
+ipa_download_distro: centos9
 ipa_kernel_upstream_url: >-
   {%- if use_tinyipa | bool -%}
   {{ tarballs_base_url }}/tinyipa/files/tinyipa-{{ ipa_upstream_release }}.vmlinuz
@@ -146,10 +139,6 @@ deploy_image_sources:
       checksum: "https://dl.rockylinux.org/pub/rocky/9/images/x86_64/CHECKSUM"
       checksum_algorithm: "sha256"
   centos:
-    8-stream:
-      image: "https://cloud.centos.org/centos/8-stream/x86_64/images/CentOS-Stream-GenericCloud-8-20230501.0.x86_64.qcow2"
-      checksum: "https://cloud.centos.org/centos/8-stream/x86_64/images/CHECKSUM"
-      checksum_algorithm: "sha256"
     9-stream:
       image: "https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20230501.0.x86_64.qcow2"
       checksum: "https://cloud.centos.org/centos/9-stream/x86_64/images/CHECKSUM"

releasenotes/notes/remove-centos8-leftovers-07b5231c395b9c81.yaml

@@ -0,0 +1,4 @@
+---
+upgrade:
+  - |
+    Completely remove CentOS Stream 8 support since it's now EoL.

scripts/test-bifrost.sh

@@ -75,7 +75,7 @@ if which setenforce &> /dev/null; then
 fi
 
 if [ ${DOWNLOAD_CUSTOM_DEPLOY_IMAGE} = "true" ] && [ ! -f "$HOME/.ssh/id_ecdsa.pub" ]; then
-    # CentOS/RHEL 8 and 9, as well as Fedora, do not work with the RSA key
+    # CentOS/RHEL 9, as well as Fedora, do not work with the RSA key
     # that the Cirros' SSH server uses. Generate an ECDSA key pair instead.
     ssh-keygen -t ECDSA -f "$HOME/.ssh/id_ecdsa" -N ""
 fi