Skip to content

Commit 3b49098

Browse files
authored
Fix danswer credential generation (#8)
* Use deterministic dummy creds * Bump tags for testing * Add comments * Bump to stable chart & image tags
1 parent 7a3b026 commit 3b49098

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

deployment/helm/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ home: https://www.danswer.ai/
55
sources:
66
- "https://github.com/danswer-ai/danswer"
77
type: application
8-
version: 0.2.1
8+
version: 0.2.2
99
appVersion: v0.5.10
1010
dependencies:
1111
- name: postgresql

deployment/helm/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ appVersionOverride: # e.g "v0.3.93"
1111
# tags to refer to downstream StackHPC-modified images.
1212
# The full image ref will be:
1313
# {{ image-name }}:{{ image-tag or appVersion }}-{{ tagSuffix }}
14-
tagSuffix: stackhpc.3
14+
tagSuffix: stackhpc.4
1515

1616
zenithClient:
1717
iconUrl: https://raw.githubusercontent.com/danswer-ai/danswer/1fabd9372d66cd54238847197c33f091a724803b/Danswer.png

web/src/app/auth/login/HeaderLogin.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { basicLogin, basicSignup } from "@/lib/user";
55
import { useRouter } from "next/navigation";
66
import { useEffect } from "react";
77
import { Spinner } from "@/components/Spinner";
8-
import { v4 as uuidv4 } from 'uuid';
98

109
export function HeaderLoginLoading({
1110
user, groups
@@ -17,8 +16,10 @@ export function HeaderLoginLoading({
1716

1817
const router = useRouter();
1918
const { popup, setPopup } = usePopup();
19+
// NOTE: As long as Danswer is only ever exposed
20+
// via Zenith then these credentials are irrelevant.
2021
const email = `${user}@default.com`;
21-
const password = `not-used-${uuidv4()}`
22+
const password = `not-used-${user}`
2223
const role = groups.includes("/admins") ? "admin" : "basic"
2324

2425
async function tryLogin() {

web/src/app/auth/login/page.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ const Page = async ({
9494
/>
9595
</>
9696
)}
97+
{/* TODO: Make header login it's own auth type */}
9798
{authTypeMetadata?.authType === "basic" && (
9899
(userHeader && groupsHeader) ?
99100
<HeaderLoginLoading user={userHeader} groups={groupsHeader.split(',')} /> : (

0 commit comments

Comments
 (0)