Move tempest source and version to build args

Author: jovial

Dockerfile

@@ -2,6 +2,9 @@ FROM ubuntu:20.04
 
 RUN sed -i s/^deb-src.*// /etc/apt/sources.list
 
+ARG TEMPEST_SOURCE=https://github.com/openstack/tempest
+ARG TEMPEST_VERSION=master
+
 RUN apt-get update && apt-get install --yes sudo python3-dev python3-pip vim git-core crudini jq iputils-ping && \
     apt clean && \
     pip3 --no-cache-dir install --upgrade pip setuptools && \
@@ -25,7 +28,7 @@ RUN crudini --set ~/.rally/rally.conf database connection sqlite:////home/rally/
 
 RUN rally db recreate
 
-RUN rally verify create-verifier --name default --type tempest
+RUN rally verify create-verifier --name default --type tempest --source $TEMPEST_SOURCE --version $TEMPEST_VERSION
 
 COPY bin/rally-verify-wrapper.sh /usr/bin/rally-verify-wrapper.sh
 COPY bin/rally-extract-tests.sh /usr/bin/rally-extract-tests.sh

bin/rally-verify-wrapper.sh

@@ -10,17 +10,6 @@
 set -eux
 
 artifacts_dir=/home/rally/artifacts
-tempest_source_default="--source /opt/tempest"
-
-tempest_source="$tempest_source_default"
-if [ ! -z ${TEMPEST_SOURCE:+x} ]; then
-    tempest_source="--source $TEMPEST_SOURCE"
-fi
-
-tempest_version=""
-if [ ! -z ${TEMPEST_VERSION:+x} ]; then
-    tempest_version="--version $TEMPEST_VERSION"
-fi
 
 if [ ! -z ${TEMPEST_LOAD_LIST:+x} ]; then
     echo "$TEMPEST_LOAD_LIST" > ~/tempest-load-list
@@ -86,10 +75,6 @@ crudini --set ~/.rally/rally.conf openstack flavor_ref_alt_disk 1
 
 rally deployment create --fromenv --name openstack
 
-if [ "$tempest_source" != "$tempest_source_default" ] || [ "$tempest_version" != "" ]; then
-    rally verify create-verifier --name tempest --type tempest $tempest_source $tempest_version
-fi
-
 if [ -f ~/tempest-overrides.conf ]; then
     rally verify configure-verifier --reconfigure --extend ~/tempest-overrides.conf
 fi