Merge pull request #41 from stackhpc/upstream/2023.1-2024-08-05

Synchronise 2023.1 with upstream

Author: markgoddard

glance/location.py

@@ -63,8 +63,19 @@ def _set_acls(self, image):
             member_ids = [m.member_id for m in member_repo.list()]
         for location in image.locations:
             if CONF.enabled_backends:
+                # NOTE(whoami-rajat): Do not set_acls if store is not defined
+                # on this node. This is possible in case of edge deployment
+                # that image location is present but the actual store is
+                # not related to this node.
+                image_store = location['metadata'].get('store')
+                if image_store not in CONF.enabled_backends:
+                    msg = (_("Store %s is not available on "
+                             "this node, skipping `_set_acls` "
+                             "call.") % image_store)
+                    LOG.debug(msg)
+                    continue
                 self.store_api.set_acls_for_multi_store(
-                    location['url'], location['metadata'].get('store'),
+                    location['url'], image_store,
                     public=public, read_tenants=member_ids,
                     context=self.context
                 )
@@ -655,8 +666,19 @@ def _set_acls(self):
             member_ids = [m.member_id for m in self.repo.list()]
             for location in self.image.locations:
                 if CONF.enabled_backends:
+                    # NOTE(whoami-rajat): Do not set_acls if store is not
+                    # defined on this node. This is possible in case of edge
+                    # deployment that image location is present but the actual
+                    # store is not related to this node.
+                    image_store = location['metadata'].get('store')
+                    if image_store not in CONF.enabled_backends:
+                        msg = (_("Store %s is not available on "
+                                 "this node, skipping `_set_acls` "
+                                 "call.") % image_store)
+                        LOG.debug(msg)
+                        continue
                     self.store_api.set_acls_for_multi_store(
-                        location['url'], location['metadata'].get('store'),
+                        location['url'], image_store,
                         public=public, read_tenants=member_ids,
                         context=self.context
                     )

releasenotes/notes/fix-set-acls-bc17b5e125425c9b.yaml

@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    `Bug #2073945 <https://bugs.launchpad.net/glance/+bug/2073945>`_:
+    Fixed issue with VM creation in DCN cases with RBD backend where
+    an edge node doesn't have the store defined which is part of the
+    image locations and the operation fails.