Skip to content

Commit 05bd2f6

Browse files
mnasiadkaAlex-Welsh
authored andcommitted
ansible-lint: Add noqa to existing no-handler violations
Change-Id: Ifc788b1f3f4fee23745e4a88bba208ff21366263 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
1 parent 7f652c3 commit 05bd2f6

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

.ansible-lint

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ exclude_paths:
99
strict: false
1010
use_default_rules: true
1111
skip_list:
12-
# [E503] Tasks that run when changed should likely be handlers
13-
- no-handler
1412
# [unnamed-task] All tasks should be named
1513
# FIXME(mgoddard): Add names to all tasks
1614
- unnamed-task

ansible/roles/bifrost/tasks/reconfigure.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
- "{{ check_results.results }}"
5858

5959
- include_tasks: start.yml
60-
when: remove_containers.changed
60+
when: remove_containers.changed # noqa no-handler
6161

6262
- name: Restart containers
6363
become: true

ansible/roles/nova/tasks/map_cell0.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,4 @@
6565
- nova_cell_settings.cell_database != nova_cell0_connection
6666

6767
- include_tasks: bootstrap_service.yml
68-
when: map_cell0.changed
68+
when: map_cell0.changed # noqa no-handler

ansible/roles/octavia/tasks/hm-interface.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
{% if openstack_cacert != '' %}--os-cacert {{ openstack_cacert }} {% endif %}
3838
port set --host {{ ansible_facts.nodename }} {{ port_id }}
3939
when:
40-
- port_info.changed
40+
- port_info.changed # noqa no-handler
4141

4242
- name: Add Octavia port to openvswitch br-int
4343
vars:
@@ -77,7 +77,7 @@
7777
name: octavia-interface
7878
daemon_reload: true
7979
state: restarted
80-
when: octavia_interface.changed
80+
when: octavia_interface.changed # noqa no-handler
8181

8282
- name: Enable and start octavia-interface.service
8383
become: true
@@ -100,4 +100,4 @@
100100
# network device(o-hm0) which is not collected, so we need gather facts again
101101
- name: Gather facts
102102
setup:
103-
when: octavia_interface.changed
103+
when: octavia_interface.changed # noqa no-handler

ansible/roles/rabbitmq/tasks/bootstrap.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@
2323
name: "{{ project_name }}_bootstrap"
2424
restart_policy: oneshot
2525
volumes: "{{ service.volumes }}"
26-
when: rabbitmq_volume is changed
26+
when: rabbitmq_volume is changed # noqa no-handler

0 commit comments

Comments
 (0)