Merge pull request #145 from stackhpc/feature/dashboard_folders

Extend support for custom Grafana dashboards

Author: dougszumski

ansible/roles/grafana/tasks/config.yml

@@ -139,34 +139,18 @@
     - inventory_hostname in groups[service.group]
     - service.enabled | bool
 
-- name: Create custom Grafana dashboards folder
-  become: true
-  vars:
-    service: "{{ grafana_services['grafana'] }}"
-  file:
-    dest: "{{ node_config_directory }}/grafana/dashboards/"
-    state: "directory"
-    mode: "0770"
-  when:
-    - grafana_custom_dashboards_folder.stat.exists
-    - grafana_custom_dashboards_folder.stat.isdir
-    - inventory_hostname in groups[service.group]
-    - service.enabled | bool
-
 - name: Copying over custom dashboards
   vars:
     service: "{{ grafana_services['grafana'] }}"
   copy:
-    src: "{{ item }}"
-    dest: "{{ node_config_directory }}/grafana/dashboards/"
+    src: "{{ node_custom_config }}/grafana/dashboards"
+    dest: "{{ node_config_directory }}/grafana/"
     mode: "0660"
   become: true
   when:
     - grafana_custom_dashboards_folder.stat.exists
     - grafana_custom_dashboards_folder.stat.isdir
     - inventory_hostname in groups[service.group]
     - service.enabled | bool
-  with_fileglob:
-    - "{{ node_custom_config }}/grafana/dashboards/*.json"
   notify:
     - Restart grafana container

doc/source/reference/logging-and-monitoring/grafana-guide.rst

@@ -35,9 +35,11 @@ Custom Dashboards Provisioning
 
 Kolla Ansible sets Custom Dashboards Provisioning using `Dashboard provider <https://grafana.com/docs/grafana/latest/administration/provisioning/#dashboards>`_.
 
-Dashboard's JSON files should be placed into
-``{{ node_custom_config }}/grafana/dashboards/`` folder.
-Dashboards will be imported to Grafana dashboards General Folder.
+Dashboard JSON files should be placed into the
+``{{ node_custom_config }}/grafana/dashboards/`` folder. The use of
+sub-folders if also supported when using a custom ``provisioning.yaml``
+file. Dashboards will be imported into the Grafana dashboards 'General'
+folder by default.
 
 Grafana provisioner config can be altered by placing ``provisioning.yaml`` to
 ``{{ node_custom_config }}/grafana/`` folder.