Skip to content

Commit 68c9cba

Browse files
committed
ansible-lint: Fix command-instead-of-module/shell
Change-Id: I4099b338b0d16bedf5731a3a63eeaad27a321d9b Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
1 parent 78f3c2b commit 68c9cba

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

.ansible-lint

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,4 @@ skip_list:
3737
- var-naming[no-role-prefix]
3838
- risky-file-permissions
3939
- risky-shell-pipe
40-
- command-instead-of-shell
41-
- command-instead-of-module
4240
- yaml[line-length]

ansible/roles/loadbalancer/tasks/config_validate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
- name: Validating haproxy config files
33
vars:
44
service: "{{ loadbalancer_services['haproxy'] }}"
5-
shell: >-
5+
command: >-
66
{{ kolla_container_engine }} exec -i haproxy haproxy
77
-c -f /etc/haproxy/haproxy.cfg -f /etc/haproxy/services.d/
88
register: haproxy_config_validation_result

ansible/roles/valkey/tasks/check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
- name: Valkey ping pong check
77
become: true
8-
shell: >-
8+
command: >-
99
{{ kolla_container_engine }} exec valkey_server valkey-cli -h {{ api_interface_address }}
1010
-a {{ valkey_master_password }} ping
1111
register: valkey_check

ansible/roles/valkey/tasks/upgrade.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
become: true
3737
delegate_to: "{{ valkey_master_host }}"
3838
run_once: true
39-
shell: >-
39+
command: >-
4040
{{ kolla_container_engine }} exec valkey_server
4141
valkey-cli -h {{ api_interface_address }} -p {{ valkey_server_port }} info replication
4242
register: valkey_replication
@@ -81,7 +81,7 @@
8181
become: true
8282
delegate_to: "{{ valkey_master_host }}"
8383
run_once: true
84-
shell: >-
84+
command: >-
8585
{{ kolla_container_engine }} exec valkey_server
8686
valkey-cli -h {{ api_interface_address }} -p {{ valkey_server_port }} info replication
8787
register: valkey_role

0 commit comments

Comments
 (0)