Do not set pid file for iscsid

yoctozepto · markgoddard · commit 77d70f0d8fba · 2021-06-21T12:02:57.000Z
Kolla Ansible runs iscsid in the foreground (-f) and a recent change to iscsid in CentOS 8 (both Linux and Stream) caused it to reject setting pid file in such a case. PID file is irrelevant in this scenario so this commit removes its parameter. Closes-Bug: #1933033 Change-Id: Ic0c4beae0c812f3ca68a6ee5cc4daa2fee0f277d (cherry picked from commit 18a0af6)
diff --git a/ansible/roles/iscsi/templates/iscsid.json.j2 b/ansible/roles/iscsi/templates/iscsid.json.j2
@@ -1,4 +1,4 @@
 {
-    "command": "iscsid -d 8 -f --pid=/run/iscsid.pid",
+    "command": "iscsid -d 8 -f",
     "config_files": []
 }
diff --git a/releasenotes/notes/bug-1933033-76746d127285cfe8.yaml b/releasenotes/notes/bug-1933033-76746d127285cfe8.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixes ``iscsid`` failing in current CentOS 8 based images due to
+    pid file being needlessly set.
+    `LP#1933033 <https://launchpad.net/bugs/1933033>`__

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`		`- "command": "iscsid -d 8 -f --pid=/run/iscsid.pid",`
	`2`	`+ "command": "iscsid -d 8 -f",`
`3`	`3`	`"config_files": []`
`4`	`4`	`}`