Fix exit code with bogus command name

markgoddard · markgoddard · commit 8c68ced1a240 · 2021-07-26T08:55:29.000Z
Running this: $ kolla-ansible bogus-command Should show usage & give a non-zero exit code. Previously it gave a zero exit code. This change fixes the issue. Closes-Bug: #1929397 Change-Id: I580c208d61d5efe115f936dfb8f3f6508acd91b2 (cherry picked from commit 86ddc94)
diff --git a/releasenotes/notes/cli-exit-code-1e6278f803dbf8e2.yaml b/releasenotes/notes/cli-exit-code-1e6278f803dbf8e2.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixes an issue where ``kolla-ansible`` exits with a zero exit code when
+    executed with a bogus command name. `LP#1929397
+    <https://bugs.launchpad.net/kolla-ansible/+bug/1929397>`__
diff --git a/tools/kolla-ansible b/tools/kolla-ansible
@@ -494,7 +494,7 @@ EOF
         exit 0
         ;;
 (*)     usage
-        exit 0
+        exit 3
         ;;
 esac
 

-Original file line number
+Diff line change
         exit 0
         ;;
 (*)     usage
 -        exit 0
 +        exit 3
         ;;
 esac