Skip to content

Commit b973729

Browse files
MargaritaShakhovamarkgoddard
authored andcommitted
Add ironic-inspector policy configuration
Fix configuration for ironic role in order to apply custom policies for ironic-inspector API Closes-Bug: #1952948 Change-Id: Id454c693f570e99ea58d2a6231f01a84b80ca56a (cherry picked from commit 590cd71)
1 parent f14caa1 commit b973729

File tree

3 files changed

+49
-7
lines changed

3 files changed

+49
-7
lines changed

ansible/roles/ironic/tasks/config.yml

Lines changed: 39 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
- item.value.enabled | bool
1313
with_dict: "{{ ironic_services }}"
1414

15-
- name: Check if policies shall be overwritten
15+
- name: Check if Ironic policies shall be overwritten
1616
stat:
1717
path: "{{ item }}"
1818
delegate_to: localhost
@@ -24,13 +24,32 @@
2424
- "{{ node_custom_config }}/ironic/"
2525
skip: true
2626

27+
- name: Check if Ironic Inspector policies shall be overwritten
28+
stat:
29+
path: "{{ item }}"
30+
delegate_to: localhost
31+
run_once: True
32+
register: ironic_inspector_policy
33+
with_first_found:
34+
- files: "{{ supported_policy_format_list }}"
35+
paths:
36+
- "{{ node_custom_config }}/ironic/inspector/"
37+
skip: true
38+
2739
- name: Set ironic policy file
2840
set_fact:
2941
ironic_policy_file: "{{ ironic_policy.results.0.stat.path | basename }}"
3042
ironic_policy_file_path: "{{ ironic_policy.results.0.stat.path }}"
3143
when:
3244
- ironic_policy.results
3345

46+
- name: Set ironic-inspector policy file
47+
set_fact:
48+
ironic_inspector_policy_file: "{{ ironic_inspector_policy.results.0.stat.path | basename }}"
49+
ironic_inspector_policy_file_path: "{{ ironic_inspector_policy.results.0.stat.path }}"
50+
when:
51+
- ironic_inspector_policy.results
52+
3453
- include_tasks: copy-certs.yml
3554
when:
3655
- kolla_copy_ca_into_containers | bool or ironic_enable_tls_backend | bool
@@ -224,12 +243,11 @@
224243
notify:
225244
- Restart ironic-ipxe container
226245

227-
- name: Copying over existing policy file
246+
- name: Copying over existing Ironic policy file
228247
vars:
229248
services_require_policy_json:
230249
- ironic-api
231250
- ironic-conductor
232-
- ironic-inspector
233251
template:
234252
src: "{{ ironic_policy_file_path }}"
235253
dest: "{{ node_config_directory }}/{{ item.key }}/{{ ironic_policy_file }}"
@@ -244,6 +262,24 @@
244262
notify:
245263
- "Restart {{ item.key }} container"
246264

265+
- name: Copying over existing Ironic Inspector policy file
266+
vars:
267+
services_require_inspector_policy_json:
268+
- ironic-inspector
269+
template:
270+
src: "{{ ironic_inspector_policy_file_path }}"
271+
dest: "{{ node_config_directory }}/{{ item.key }}/{{ ironic_inspector_policy_file }}"
272+
mode: "0660"
273+
become: true
274+
when:
275+
- ironic_inspector_policy_file is defined
276+
- item.key in services_require_inspector_policy_json
277+
- inventory_hostname in groups[item.value.group]
278+
- item.value.enabled | bool
279+
with_dict: "{{ ironic_services }}"
280+
notify:
281+
- "Restart {{ item.key }} container"
282+
247283
- name: Copying over ironic-api-wsgi.conf
248284
template:
249285
src: "ironic-api-wsgi.conf.j2"

ansible/roles/ironic/templates/ironic-inspector.json.j2

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
"dest": "/etc/ironic-inspector/inspector.conf",
77
"owner": "ironic-inspector",
88
"perm": "0600"
9-
}{% if ironic_policy_file is defined %},
9+
}{% if ironic_inspector_policy_file is defined %},
1010
{
11-
"source": "{{ container_config_directory }}/{{ ironic_policy_file }}",
12-
"dest": "/etc/ironic/{{ ironic_policy_file }}",
13-
"owner": "ironic",
11+
"source": "{{ container_config_directory }}/{{ ironic_inspector_policy_file }}",
12+
"dest": "/etc/ironic-inspector/{{ ironic_inspector_policy_file }}",
13+
"owner": "ironic-inspector",
1414
"perm": "0600"
1515
}{% endif %}
1616
]
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
fixes:
3+
- |
4+
Ironic API and Ironic Inspector API use separate policy files. Ironic role
5+
was updated to be able to handle both policies separately.
6+
`LP#1952948 <https://bugs.launchpad.net/kolla-ansible/+bug/1952948>`__

0 commit comments

Comments
 (0)