Merge "Set changed_when to false for group_by tasks" into stable/victoria

Author: Zuul

ansible/gather-facts.yml

@@ -17,6 +17,7 @@
     - name: Group hosts to determine when using --limit
       group_by:
         key: "all_using_limit_{{ (ansible_play_batch | length) != (groups['all'] | length) }}"
+      changed_when: false
   tags: always
 
 # NOTE(pbourke): This case covers deploying subsets of hosts using --limit. The

ansible/roles/haproxy/handlers/main.yml

@@ -24,6 +24,7 @@
     re_safe_address: "{{ kolla_internal_vip_address | regex_escape }}"
   group_by:
     key: kolla_ha_is_master_{{ ip_addr_output.stdout is regex('\b' + re_safe_address + '\b') }}
+  changed_when: false
   when:
     - kolla_action != "config"
   listen:

ansible/roles/haproxy/tasks/precheck.yml

@@ -16,13 +16,15 @@
 - name: Group hosts by whether they are running keepalived
   group_by:
     key: "keepalived_running_{{ container_facts['keepalived'] is defined }}"
+  changed_when: false
   when:
     - enable_keepalived | bool
     - inventory_hostname in groups['haproxy']
 
 - name: Group hosts by whether they are running HAProxy
   group_by:
     key: "haproxy_running_{{ container_facts['haproxy'] is defined }}"
+  changed_when: false
   when:
     - enable_haproxy | bool
     - inventory_hostname in groups['haproxy']

ansible/roles/keystone/tasks/bootstrap_service.yml

@@ -14,6 +14,7 @@
 - name: Group nodes where keystone_fernet is running
   group_by:
     key: keystone_fernet_{{ container_facts['keystone_fernet'].State | default('bootstrap') }}
+  changed_when: false
 
 # NOTE(mgoddard): If we bootstrap Fernet keys on an existing cluster, this
 # would overwrite existing keys, and invalidate tokens created from them.

ansible/roles/mariadb/tasks/lookup_cluster.yml

@@ -10,6 +10,7 @@
 - name: Divide hosts by their MariaDB volume availability
   group_by:
     key: mariadb_had_volume_{{ mariadb_volume is not changed }}
+  changed_when: false
 
 - name: Establish whether the cluster has already existed
   set_fact:
@@ -29,6 +30,7 @@
     - name: Divide hosts by their MariaDB service port liveness
       group_by:
         key: mariadb_port_alive_{{ check_mariadb_port_liveness is success }}
+      changed_when: false
 
     - name: Fail on existing but stopped cluster
       fail:
@@ -64,6 +66,7 @@
     - name: Divide hosts by their MariaDB service WSREP sync status
       group_by:
         key: mariadb_sync_status_{{ mariadb_sync_status | default('NA') }}
+      changed_when: false
 
     - name: Fail when MariaDB services are not synced across the whole cluster
       fail:

ansible/site.yml

@@ -11,10 +11,12 @@
     - name: Group hosts based on Kolla action
       group_by:
         key: "kolla_action_{{ kolla_action }}"
+      changed_when: false
 
     - name: Group hosts based on enabled services
       group_by:
         key: "{{ item }}"
+      changed_when: false
       with_items:
         - enable_aodh_{{ enable_aodh | bool }}
         - enable_barbican_{{ enable_barbican | bool }}