neutron: Template vpnaas config only when it is enabled

Closes-Bug: #2119733

Change-Id: I917437834dd159e107309584e84f5b14b72100d2
Signed-off-by: Michal Nasiadka <[email protected]>
(cherry picked from commit 249c33f)

Author: mnasiadka

ansible/roles/neutron/tasks/config.yml

@@ -118,6 +118,7 @@
     dest: "{{ node_config_directory }}/{{ item.key }}/neutron_vpnaas.conf"
     mode: "0660"
   when:
+    - enable_neutron_vpnaas | bool
     - item.key in services_need_neutron_vpnaas_conf
   with_dict: "{{ neutron_services | select_services_enabled_and_mapped_to_host }}"
 

ansible/roles/neutron/templates/neutron-l3-agent-wrapper.sh.j2

@@ -17,6 +17,6 @@ neutron-netns-cleanup \
 
 neutron-l3-agent \
         --config-file /etc/neutron/neutron.conf \
-        --config-file /etc/neutron/neutron_vpnaas.conf \
-        --config-file /etc/neutron/l3_agent.ini{% if enable_neutron_fwaas | bool %} \
+        --config-file /etc/neutron/l3_agent.ini{% if enable_neutron_vpnaas | bool %} \
+        --config-file /etc/neutron/neutron_vpnaas.conf{% endif %}{% if enable_neutron_fwaas | bool %} \
         --config-file /etc/neutron/fwaas_driver.ini{% endif %}

ansible/roles/neutron/templates/neutron-l3-agent.json.j2

@@ -12,13 +12,13 @@
             "dest": "/etc/neutron/neutron.conf",
             "owner": "neutron",
             "perm": "0600"
-        },
+        }{% if enable_neutron_vpnaas | bool %},
         {
             "source": "{{ container_config_directory }}/neutron_vpnaas.conf",
             "dest": "/etc/neutron/neutron_vpnaas.conf",
             "owner": "neutron",
             "perm": "0600"
-        }{% if enable_neutron_fwaas | bool %},
+        }{% endif %}{% if enable_neutron_fwaas | bool %},
         {
             "source": "{{ container_config_directory }}/fwaas_driver.ini",
             "dest": "/etc/neutron/fwaas_driver.ini",

ansible/roles/neutron/templates/neutron-server.json.j2

@@ -1,5 +1,5 @@
 {
-    "command": "neutron-server --config-file /etc/neutron/neutron.conf {% if neutron_plugin_agent in ['openvswitch', 'linuxbridge', 'ovn'] %} --config-file /etc/neutron/plugins/ml2/ml2_conf.ini --config-file /etc/neutron/neutron_vpnaas.conf {% elif neutron_plugin_agent in ['vmware_nsxv', 'vmware_nsxv3', 'vmware_nsxp', 'vmware_dvs'] %} --config-file /etc/neutron/plugins/vmware/nsx.ini {% endif %}{% if enable_neutron_fwaas | bool %}--config-file /etc/neutron/fwaas_driver.ini{% endif %}",
+    "command": "neutron-server --config-file /etc/neutron/neutron.conf {% if neutron_plugin_agent in ['openvswitch', 'linuxbridge', 'ovn'] %} --config-file /etc/neutron/plugins/ml2/ml2_conf.ini {% if enable_neutron_vpnaas | bool %}--config-file /etc/neutron/neutron_vpnaas.conf{% endif %}{% elif neutron_plugin_agent in ['vmware_nsxv', 'vmware_nsxv3', 'vmware_nsxp', 'vmware_dvs'] %} --config-file /etc/neutron/plugins/vmware/nsx.ini {% endif %}{% if enable_neutron_fwaas | bool %}--config-file /etc/neutron/fwaas_driver.ini{% endif %}",
     "config_files": [
         {
             "source": "{{ container_config_directory }}/neutron.conf",
@@ -15,12 +15,14 @@
             "perm": "0600"
         },
 {% endif %}
+{% if enable_neutron_vpnaas | bool %}
         {
             "source": "{{ container_config_directory }}/neutron_vpnaas.conf",
             "dest": "/etc/neutron/neutron_vpnaas.conf",
             "owner": "neutron",
             "perm": "0600"
         },
+{% endif %}
 {% if enable_neutron_taas | bool %}
         {
             "source": "{{ container_config_directory }}/neutron_taas.conf",

ansible/roles/neutron/templates/neutron_vpnaas.conf.j2

@@ -1,8 +1,6 @@
-{% if enable_neutron_vpnaas | bool %}
 [service_providers]
 {% if neutron_plugin_agent == 'vmware_nsxv' %}
 service_provider = VPN:vmware:vmware_nsx.services.vpnaas.nsxv.ipsec_driver.NSXvIPsecVpnDriver:default
 {% else %}
 service_provider = VPN:openswan:neutron_vpnaas.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default
 {% endif %}
-{% endif %}