Skip to content

Commit f6fa470

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Use Docker healthchecks for memcached services" into stable/wallaby
2 parents d5a60e9 + 3bbf1a8 commit f6fa470

File tree

4 files changed

+22
-0
lines changed

4 files changed

+22
-0
lines changed

ansible/roles/memcached/defaults/main.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ memcached_services:
99
group: "memcached"
1010
volumes: "{{ memcached_default_volumes + memcached_extra_volumes }}"
1111
dimensions: "{{ memcached_dimensions }}"
12+
healthcheck: "{{ memcached_healthcheck }}"
1213
haproxy:
1314
memcached:
1415
enabled: "{{ enable_memcached|bool and enable_haproxy_memcached|bool }}"
@@ -36,6 +37,19 @@ memcached_tag: "{{ openstack_tag }}"
3637
memcached_image_full: "{{ memcached_image }}:{{ memcached_tag }}"
3738
memcached_dimensions: "{{ default_container_dimensions }}"
3839

40+
memcached_enable_healthchecks: "{{ enable_container_healthchecks }}"
41+
memcached_healthcheck_interval: "{{ default_container_healthcheck_interval }}"
42+
memcached_healthcheck_retries: "{{ default_container_healthcheck_retries }}"
43+
memcached_healthcheck_start_period: "{{ default_container_healthcheck_start_period }}"
44+
memcached_healthcheck_test: ["CMD-SHELL", "healthcheck_listen memcached {{ memcached_port }}"]
45+
memcached_healthcheck_timeout: "{{ default_container_healthcheck_timeout }}"
46+
memcached_healthcheck:
47+
interval: "{{ memcached_healthcheck_interval }}"
48+
retries: "{{ memcached_healthcheck_retries }}"
49+
start_period: "{{ memcached_healthcheck_start_period }}"
50+
test: "{% if memcached_enable_healthchecks | bool %}{{ memcached_healthcheck_test }}{% else %}NONE{% endif %}"
51+
timeout: "{{ memcached_healthcheck_timeout }}"
52+
3953
memcached_default_volumes:
4054
- "{{ node_config_directory }}/memcached/:{{ container_config_directory }}/:ro"
4155
- "/etc/localtime:/etc/localtime:ro"

ansible/roles/memcached/handlers/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
name: "{{ service.container_name }}"
1111
volumes: "{{ service.volumes }}"
1212
dimensions: "{{ service.dimensions }}"
13+
healthcheck: "{{ service.healthcheck | default(omit) }}"
1314
when:
1415
- kolla_action != "config"

ansible/roles/memcached/tasks/check-containers.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
image: "{{ service.image }}"
1111
volumes: "{{ service.volumes }}"
1212
dimensions: "{{ service.dimensions }}"
13+
healthcheck: "{{ service.healthcheck | default(omit) }}"
1314
when:
1415
- inventory_hostname in groups[service.group]
1516
- service.enabled | bool
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
features:
3+
- |
4+
Implements container healthchecks for memcached services.
5+
See `blueprint
6+
<https://blueprints.launchpad.net/kolla-ansible/+spec/container-health-check>`__

0 commit comments

Comments
 (0)