Skip to content

Commit f6ff824

Browse files
mnasiadkaAlex-Welsh
authored andcommitted
ansible-lint: Fix name[play]
Change-Id: I82310a2ebfa326a01424c7469d4eb9d440dc9b9c Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
1 parent a9aae92 commit f6ff824

File tree

8 files changed

+22
-13
lines changed

8 files changed

+22
-13
lines changed

.ansible-lint

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,5 @@ skip_list:
1919
- fqcn-builtins
2020
# FQCNs again, now for module actions
2121
- fqcn[action]
22-
# TODO(frickler): Discuss these in detail, skipping for now to unblock things
23-
- name[play]
2422
- var-naming[no-role-prefix]
2523
- yaml[line-length]

ansible/certificates.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
2-
- import_playbook: gather-facts.yml
2+
- name: Gather facts
3+
import_playbook: gather-facts.yml
34
when: >-
45
kolla_enable_tls_backend | default(false) | bool or
56
rabbitmq_enable_tls | default(false) | bool or

ansible/kolla-host.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
2-
- import_playbook: gather-facts.yml
2+
- name: Gather facts
3+
import_playbook: gather-facts.yml
34

45
- name: Apply role baremetal
56
hosts: baremetal

ansible/migrate-container-engine.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
2-
- import_playbook: gather-facts.yml
2+
- name: Gather facts
3+
import_playbook: gather-facts.yml
34
vars:
45
kolla_action: migrate-container-engine
56

ansible/nova-libvirt-cleanup.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
2-
- import_playbook: gather-facts.yml
2+
- name: Gather facts
3+
import_playbook: gather-facts.yml
34

45
- name: Remove nova_libvirt container
56
gather_facts: false

ansible/prune-images.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
2-
- import_playbook: gather-facts.yml
2+
- name: Gather facts
3+
import_playbook: gather-facts.yml
34

45
- name: Apply role prune-images
56
hosts: baremetal

ansible/rabbitmq-upgrade.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
2-
- import_playbook: gather-facts.yml
2+
- name: Gather facts
3+
import_playbook: gather-facts.yml
34

45
- name: Group hosts based on configuration (RabbitMQ Only)
56
hosts: all
@@ -15,7 +16,8 @@
1516
changed_when: false
1617
tags: always
1718

18-
- import_playbook: rabbitmq.yml
19+
- name: Run RabbitMQ upgrade
20+
import_playbook: rabbitmq.yml
1921
vars:
2022
kolla_action: upgrade
2123
rabbitmq_image: "{{ docker_registry ~ '/' if docker_registry else '' }}{{ docker_namespace }}/rabbitmq-{{ rabbitmq_version_suffix | regex_replace('\\.', '-') }}"

ansible/site.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
2-
- import_playbook: gather-facts.yml
2+
- name: Gather facts
3+
import_playbook: gather-facts.yml
34

45
# NOTE(mgoddard): In large environments, even tasks that are skipped can take a
56
# significant amount of time. This is an optimisation to prevent any tasks
@@ -427,7 +428,8 @@
427428

428429
# MariaDB deployment is more complicated than other services, so is covered in
429430
# its own playbook.
430-
- import_playbook: mariadb.yml
431+
- name: Apply role mariadb
432+
import_playbook: mariadb.yml
431433

432434
- name: Apply role memcached
433435
gather_facts: false
@@ -503,7 +505,8 @@
503505
roles:
504506
- { role: multipathd, tags: multipathd }
505507

506-
- import_playbook: rabbitmq.yml
508+
- name: Apply role rabbitmq
509+
import_playbook: rabbitmq.yml
507510

508511
- name: Apply role etcd
509512
gather_facts: false
@@ -659,7 +662,8 @@
659662

660663
# Nova deployment is more complicated than other services, so is covered in its
661664
# own playbook.
662-
- import_playbook: nova.yml
665+
- name: Apply role nova
666+
import_playbook: nova.yml
663667

664668
- name: Apply role neutron
665669
gather_facts: false

0 commit comments

Comments
 (0)