Skip to content

Commit 251a245

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Improve offline build scenario." into stable/victoria
2 parents cfdacc2 + 865e3f1 commit 251a245

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

docker/base/Dockerfile.j2

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ RUN {{ macros.install_packages(base_centos_yum_repo_packages | customizable("cen
248248
{% set base_centos_packages = [
249249
'ca-certificates',
250250
'curl',
251+
'dumb-init',
251252
'findutils',
252253
'iproute',
253254
'iscsi-initiator-utils',
@@ -319,6 +320,7 @@ COPY apt_preferences /etc/apt/preferences.d/kolla-custom
319320
{% set base_apt_packages = [
320321
'apt-utils',
321322
'curl',
323+
'dumb-init',
322324
'gawk',
323325
'iproute2',
324326
'kmod',
@@ -330,8 +332,8 @@ COPY apt_preferences /etc/apt/preferences.d/kolla-custom
330332
'python3-pip',
331333
'socat',
332334
'sudo',
333-
'tgt']
334-
%}
335+
'tgt'
336+
] %}
335337

336338
{% if base_distro == 'ubuntu' %}
337339
{# 391A9AA2147192839E9DB0315EDB1B62EC4926EA -- Canonical Cloud Archive Signing Key <[email protected]> #}
@@ -416,16 +418,7 @@ COPY httpd_setup.sh /usr/local/bin/kolla_httpd_setup
416418
COPY sudoers /etc/sudoers
417419

418420
{% if use_dumb_init %}
419-
420-
{% block dumb_init_installation %}
421-
422-
RUN curl -sSL https://github.com/Yelp/dumb-init/releases/download/v1.2.2/dumb-init_1.2.2_{{debian_arch}} -o /usr/local/bin/dumb-init \
423-
&& chmod +x /usr/local/bin/dumb-init
424-
425-
{% endblock %}
426-
427421
ENTRYPOINT ["dumb-init", "--single-child", "--"]
428-
429422
{% endif %}
430423

431424
{% if docker_healthchecks %}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
features:
3+
- |
4+
Improve the way offline scenario are supported:
5+
* Switching dumb-init installation to distribution provided packages.

0 commit comments

Comments
 (0)