Skip to content

Commit 29fbfbe

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "rabbitmq: Use novemberain repos for Debian/Ubuntu"
2 parents fcfa327 + 47b593d commit 29fbfbe

File tree

4 files changed

+43
-10
lines changed

4 files changed

+43
-10
lines changed

docker/base/Dockerfile.j2

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,16 @@ COPY apt_preferences /etc/apt/preferences.d/kolla-custom
283283
] %}
284284

285285
{% set base_apt_keys = [
286-
{'name': 'erlang-ppa', 'keyid': 'F77F1EDA57EBB1CC'},
287286
{'name': 'rabbitmq', 'keyid': '9F4587F226208342'},
288287
{'name': 'haproxy', 'keyid': 'CFFB779AADC995E4F350A060505D97A41C61B9CD'},
289288
] %}
290289

290+
{% if base_arch == 'aarch64' %}
291+
{% set base_apt_keys = base_apt_keys + [{'name': 'erlang-ppa', 'keyid': 'F77F1EDA57EBB1CC'}] %}
292+
{% else %}
293+
{% set base_apt_keys = base_apt_keys + [{'name': 'erlang-ppa', 'keyid': 'E495BB49CC4BBE5B'}] %}
294+
{% endif %}
295+
291296
{# NOTE(hrw): type field defaults to 'asc' which is used for single keys #}
292297
{% set base_remote_apt_keys = [
293298
{'name': 'grafana', 'url': 'https://rpm.grafana.com/gpg.key'},

kolla/template/methods.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,10 @@ def handle_repos(context, reponames, mode):
126126
>>/etc/apt/sources.list.d/{repo}.sources \
127127
&& echo 'Signed-By: /etc/kolla/apt-keys/{repo_list[repo]['gpg_key']}' \
128128
>>/etc/apt/sources.list.d/{repo}.sources \
129+
&& """
130+
if repo_list[repo]['arch']:
131+
commands += f"""echo 'Architectures: {repo_list[repo]['arch']}' \
132+
>>/etc/apt/sources.list.d/{repo}.sources \
129133
&& """
130134
except KeyError:
131135
# NOTE(hrw): we ignore missing repositories for a given

kolla/template/repos.yaml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ debian:
7373
component: ""
7474
gpg_key: "proxysql.asc"
7575
rabbitmq:
76-
url: "https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian"
77-
suite: "bookworm"
76+
url: "https://ppa1.novemberain.com/rabbitmq/rabbitmq-server/deb/debian"
77+
suite: "bullseye"
7878
component: "main"
7979
gpg_key: "rabbitmq.gpg"
8080
td-agent:
@@ -122,9 +122,10 @@ debian-aarch64:
122122
component: ""
123123
gpg_key: "proxysql.asc"
124124
rabbitmq:
125-
url: "https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian"
126-
suite: "bookworm"
125+
url: "https://ppa1.novemberain.com/rabbitmq/rabbitmq-server/deb/debian"
126+
suite: "bullseye"
127127
component: "main"
128+
arch: "amd64"
128129
gpg_key: "rabbitmq.gpg"
129130
td-agent:
130131
url: "http://packages.treasuredata.com/4/ubuntu/jammy"
@@ -170,7 +171,7 @@ rocky-aarch64:
170171

171172
ubuntu:
172173
erlang:
173-
url: "https://ppa.launchpadcontent.net/rabbitmq/rabbitmq-erlang/ubuntu"
174+
url: "https://ppa1.novemberain.com/rabbitmq/rabbitmq-erlang/deb/ubuntu"
174175
suite: "jammy"
175176
component: "main"
176177
gpg_key: "erlang-ppa.gpg"
@@ -205,7 +206,7 @@ ubuntu:
205206
component: ""
206207
gpg_key: "proxysql.asc"
207208
rabbitmq:
208-
url: "https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu"
209+
url: "https://ppa1.novemberain.com/rabbitmq/rabbitmq-server/deb/ubuntu"
209210
suite: "jammy"
210211
component: "main"
211212
gpg_key: "rabbitmq.gpg"
@@ -252,9 +253,10 @@ ubuntu-aarch64:
252253
component: ""
253254
gpg_key: "proxysql.asc"
254255
rabbitmq:
255-
url: "https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu"
256+
url: "https://ppa1.novemberain.com/rabbitmq/rabbitmq-server/deb/ubuntu"
256257
suite: "jammy"
257258
component: "main"
259+
arch: "amd64"
258260
gpg_key: "rabbitmq.gpg"
259261
td-agent:
260262
url: "http://packages.treasuredata.com/4/ubuntu/jammy/"

kolla/tests/test_methods.py

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,28 @@ def test_enable_repos_debian(self):
7878
expectCmd += ">>/etc/apt/sources.list.d/grafana.sources"
7979
self.assertEqual(expectCmd, result)
8080

81+
def test_enable_repos_debian_arch(self):
82+
template_vars = {
83+
'base_arch': 'aarch64',
84+
'base_distro': 'debian',
85+
'base_package_type': 'deb'
86+
}
87+
88+
result = methods.handle_repos(template_vars, ['rabbitmq'], 'enable')
89+
expectCmd = "RUN echo 'Uris: https://ppa1.novemberain.com/rabbitmq/rabbitmq-server/deb/debian' " # noqa: E501
90+
expectCmd += ">/etc/apt/sources.list.d/rabbitmq.sources && "
91+
expectCmd += "echo 'Components: main' "
92+
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources && "
93+
expectCmd += "echo 'Types: deb' "
94+
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources && "
95+
expectCmd += "echo 'Suites: bullseye' "
96+
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources && "
97+
expectCmd += "echo 'Signed-By: /etc/kolla/apt-keys/rabbitmq.gpg' "
98+
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources && "
99+
expectCmd += "echo 'Architectures: amd64' "
100+
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources"
101+
self.assertEqual(expectCmd, result)
102+
81103
def test_enable_repos_debian_missing_repo(self):
82104
template_vars = {
83105
'base_arch': 'x86_64',
@@ -111,13 +133,13 @@ def test_enable_repos_debian_multiple(self):
111133
expectCmd += ">>/etc/apt/sources.list.d/grafana.sources && "
112134

113135
expectCmd += "echo 'Uris: "
114-
expectCmd += "https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian' " # noqa: E501
136+
expectCmd += "https://ppa1.novemberain.com/rabbitmq/rabbitmq-server/deb/debian' " # noqa: E501
115137
expectCmd += ">/etc/apt/sources.list.d/rabbitmq.sources && "
116138
expectCmd += "echo 'Components: main' "
117139
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources && "
118140
expectCmd += "echo 'Types: deb' "
119141
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources && "
120-
expectCmd += "echo 'Suites: bookworm' "
142+
expectCmd += "echo 'Suites: bullseye' "
121143
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources && "
122144
expectCmd += "echo 'Signed-By: /etc/kolla/apt-keys/rabbitmq.gpg' "
123145
expectCmd += ">>/etc/apt/sources.list.d/rabbitmq.sources"

0 commit comments

Comments
 (0)