Fix multiple CI issues

1. Pin openstacksdk and client libraries in kolla-toolbox

Stein and below only.

openstacksdk released 0.45.0 (and possibly 0.44.0 as well) which dropped
py2 compat but did not advertise the fact. It was amended later but it
will now always affect kolla images until pinned to older.

The observable error is:
"ImportError: No module named queue"

Since Train we pin u-c, but not before that.

This change introduces a version constraint for openstacksdk and client
libs:

- python-novaclient
- python-cinderclient
- python-keystoneclient
- python-glanceclient

2. Make deploy jobs non-voting

For similar reasons to 1., the deploy jobs fail when using the openstack
client for testing. Due to a dependency loop between these two projects,
we must make these jobs non-voting to fix the image build. This should
be reverted ASAP.

3. CI: Add https match for mirror.centos.org to template-overrides

Some CentOS repos (currently one - Ceph NFS Ganesha) use
https://mirror.centos.org instead of http:// and we break
their definition by removing mirrorlist= entry and not inserting baseurl
entry due to a missing match.

Original Change-Id: I7b29f8c6be80820042023d2b85162d5cc9a65f08

Change-Id: I8c2da6437333210a7926f2deb926ab5d1c93c3c6
Closes-Bug: #1870349

Author: markgoddard

.zuul.d/centos.yaml

@@ -4,9 +4,15 @@
       jobs:
         - kolla-build-centos-binary
         - kolla-build-centos-source
-        - kolla-ansible-centos-source
-        - kolla-ansible-centos-binary
-        - kolla-ansible-centos-source-upgrade
+        - kolla-ansible-centos-source:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
+        - kolla-ansible-centos-binary:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
+        - kolla-ansible-centos-source-upgrade:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
         - tripleo-build-containers-centos-7:
             # FIXME(yoctozepto): set to voting when TripleO CI is fixed
             voting: false

.zuul.d/oraclelinux.yaml

@@ -4,8 +4,12 @@
       jobs:
         - kolla-build-oraclelinux-binary
         - kolla-build-oraclelinux-source
-        - kolla-ansible-oraclelinux-source
-        - kolla-ansible-oraclelinux-binary
+        - kolla-ansible-oraclelinux-source:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
+        - kolla-ansible-oraclelinux-binary:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
         - kolla-ansible-oraclelinux-source-ceph:
             files: ^docker\/(ceph|cinder)\/.*
     gate:

.zuul.d/ubuntu.yaml

@@ -4,9 +4,15 @@
       jobs:
         - kolla-build-ubuntu-binary
         - kolla-build-ubuntu-source
-        - kolla-ansible-ubuntu-source
-        - kolla-ansible-ubuntu-binary
-        - kolla-ansible-ubuntu-source-upgrade
+        - kolla-ansible-ubuntu-source:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
+        - kolla-ansible-ubuntu-binary:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
+        - kolla-ansible-ubuntu-source-upgrade:
+            # FIXME(mgoddard): Revert this when kolla-ansible CI passes.
+            voting: false
         - kolla-ansible-ubuntu-source-zun:
             files: ^docker\/(zun|kuryr)\/.*
         - kolla-ansible-ubuntu-source-ceph:

docker/kolla-toolbox/Dockerfile.j2

@@ -64,9 +64,14 @@ ENV PATH {{ virtualenv_path }}/bin:$PATH
         '"cmd2<0.9.0"',
         'influxdb',
         'mysqlclient',
+        '"openstacksdk<0.28.0"',
         'os-client-config==1.29.0',
         'pbr==4.0.0',
         'pymongo',
+        '"python-cinderclient<5.0.0"',
+        '"python-glanceclient<2.17.0"',
+        '"python-keystoneclient<3.20.0"',
+        '"python-novaclient<14.0.0"',
         'python-openstackclient==3.14.0',
         'pytz',
         'pyudev',

tests/templates/template_overrides.j2

@@ -23,6 +23,9 @@ RUN echo 'APT::Get::AllowUnauthenticated "true";' > /etc/apt/apt.conf.d/99allow-
 
 RUN sed -i -e "/^mirrorlist/d" \
         -e "s|^#baseurl=http://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|" \
+        -e "s|^#baseurl=https://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|" \
+        -e "s|^baseurl=http://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|" \
+        -e "s|^baseurl=https://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|" \
         /etc/yum.repos.d/CentOS-Base.repo
 
 {% raw %}
@@ -44,7 +47,9 @@ RUN sed -i -e  "/^mirrorlist/d" \
         -e "/^metalink/d" \
         -e "s|^#baseurl=http://download.fedoraproject.org/pub|baseurl=http://{{ nodepool_mirror_host }}|g" \
         -e "s|^baseurl=http://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
+        -e "s|^baseurl=https://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
         -e "s|^#baseurl=http://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
+        -e "s|^#baseurl=https://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
         -e "s|^baseurl=https://packages.elastic.co|baseurl={{ nodepool_elastic_proxy }}|g" \
         -e "s|^baseurl=https://packagecloud.io/grafana|baseurl={{ nodepool_grafana_proxy }}|g" \
         -e "s|^baseurl=https://trunk.rdoproject.org|baseurl=http://{{ nodepool_rdo_proxy }}|g" \
@@ -59,8 +64,10 @@ RUN sed -i -e  "/^mirrorlist/d" \
 RUN sed -i -e "/^mirrorlist/d" \
         -e "/^metalink/d" \
         -e "s|^#baseurl=http://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
+        -e "s|^#baseurl=https://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
         -e "s|^#baseurl=http://download.fedoraproject.org/pub|baseurl=http://{{ nodepool_mirror_host }}|g" \
         -e "s|^baseurl=http://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
+        -e "s|^baseurl=https://mirror.centos.org|baseurl=http://{{ nodepool_mirror_host }}|g" \
         -e "s|^baseurl=https://packages.elastic.co|baseurl={{ nodepool_elastic_proxy }}|g" \
         -e "s|^baseurl=https://packagecloud.io/grafana|baseurl={{ nodepool_grafana_proxy }}|g" \
         -e "s|^baseurl=https://trunk.rdoproject.org|baseurl=http://{{ nodepool_rdo_proxy }}|g" \