Skip to content

Commit 57c16d0

Browse files
markgoddardyoctozepto
authored andcommitted
mariadb: Fix repository URLs
The MariaDB project changed the location of the repositories, and the old URLs no longer work. Fix added for stable branches: Wrap version detection for docker module since it can fail for docker >= 6.0. Additionally, for Victoria, this disables the monasca-grafana building on CentOS. Closes-Bug: #1988121 Change-Id: Ia094cd1e29232c47d1fb26e00de569677bc5b8a1 (cherry picked from commit 94fad9f) (cherry picked from commit b3e7221)
1 parent 7fac7e7 commit 57c16d0

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

kolla/image/build.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ class Status(Enum):
127127

128128
'centos': {
129129
"hacluster-pcs", # Missing crmsh package
130+
"monasca-grafana", # Too old Ruby now and not supported well
130131
"nova-spicehtml5proxy", # Missing spicehtml5 package
131132
"ovsdpdk", # Not supported on CentOS
132133
"tgtd", # Not supported on CentOS 8
@@ -349,9 +350,14 @@ def push_image(self, image):
349350

350351
# Since docker 3.0.0, the argument of 'insecure_registry' is removed.
351352
# To be compatible, set 'insecure_registry=True' for old releases.
352-
dc_running_ver = StrictVersion(docker.version)
353-
if dc_running_ver < StrictVersion('3.0.0'):
354-
kwargs['insecure_registry'] = True
353+
# NOTE(frickler): The version check will fail for docker >= 6.0, but
354+
# in that case we know that the workaround isn't needed.
355+
try:
356+
dc_running_ver = StrictVersion(docker.version)
357+
if dc_running_ver < StrictVersion('3.0.0'):
358+
kwargs['insecure_registry'] = True
359+
except TypeError:
360+
pass
355361

356362
for response in self.dc.push(image.canonical_name, **kwargs):
357363
if 'stream' in response:

kolla/template/repos.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ debian:
5454
influxdb: "deb https://repos.influxdata.com/debian buster stable"
5555
logstash: "deb [arch=amd64] https://artifacts.elastic.co/packages/oss-6.x/apt stable main"
5656
kibana: "deb [arch=amd64] https://artifacts.elastic.co/packages/oss-6.x/apt stable main"
57-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/debian buster main"
57+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/debian buster main"
5858
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian buster main"
5959
td-agent: "deb http://packages.treasuredata.com/4/debian/buster buster contrib"
6060

@@ -66,7 +66,7 @@ debian-aarch64:
6666
logstash: "deb [arch=amd64] https://artifacts.elastic.co/packages/oss-6.x/apt stable main"
6767
kibana: "deb [arch=amd64] https://artifacts.elastic.co/packages/oss-6.x/apt stable main"
6868
libvirt: "deb https://obs.linaro.org/repos/home:/marcin.juszkiewicz/debian-buster ./"
69-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/debian buster main"
69+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/debian buster main"
7070
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian buster main"
7171
td-agent: "deb http://packages.treasuredata.com/4/debian/buster buster contrib"
7272

@@ -77,7 +77,7 @@ ubuntu:
7777
influxdb: "deb https://repos.influxdata.com/ubuntu focal stable"
7878
logstash: "deb https://artifacts.elastic.co/packages/oss-6.x/apt stable main"
7979
kibana: "deb https://artifacts.elastic.co/packages/oss-6.x/apt stable main"
80-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/ubuntu focal main"
80+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/ubuntu focal main"
8181
qdrouterd: "deb http://ppa.launchpad.net/qpid/released/ubuntu/ focal main"
8282
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu focal main"
8383
td-agent: "deb http://packages.treasuredata.com/4/ubuntu/focal/ focal contrib"
@@ -88,7 +88,7 @@ ubuntu-aarch64:
8888
grafana: "deb https://packages.grafana.com/oss/deb stable main"
8989
influxdb: "deb https://repos.influxdata.com/ubuntu focal stable"
9090
logstash: "deb [arch=amd64] https://artifacts.elastic.co/packages/oss-6.x/apt stable main"
91-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/ubuntu bionic main"
91+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/ubuntu bionic main"
9292
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu focal main"
9393
td-agent: "deb http://packages.treasuredata.com/4/ubuntu/focal/ focal contrib"
9494

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
Fixes problems when running with docker-py >=6.
5+
`LP#1988121 <https://launchpad.net/bugs/1988121>`__

0 commit comments

Comments
 (0)