Skip to content

Commit a41001f

Browse files
yoctozeptohrw
andcommitted
Upgrade pip and friends in source images
New pip has nice features for detection of conflicting requirements. When installing from PyPI, as we do in source images, running the latest pip+setuptools+wheel is recommended. Co-authored-by: Marcin Juszkiewicz <[email protected]> Change-Id: I4ae3a82cc796a60450c2a35beba32972964bc5d0
1 parent 1a9d5a1 commit a41001f

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

docker/kolla-toolbox/Dockerfile.j2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ ENV PATH {{ virtualenv_path }}/bin:$PATH
9494
] %}
9595

9696
COPY requirements.yml /var/lib/ansible/
97-
RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable("pip_packages")) }} \
97+
RUN {{ macros.install_pip(['pip', 'wheel', 'setuptools']) }} \
98+
&& {{ macros.install_pip(kolla_toolbox_pip_packages | customizable("pip_packages")) }} \
9899
&& mkdir -p /etc/ansible /usr/share/ansible \
99100
&& echo 'localhost ansible_connection=local ansible_python_interpreter={{ virtualenv_path }}/bin/python' > /etc/ansible/hosts \
100101
&& sed -i 's| "identity_api_version": "2.0",| "identity_api_version": "3",|' {{ os_client_config }} \

docker/openstack-base/Dockerfile.j2

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,8 @@ RUN ln -s openstack-base-source/* /requirements \
328328

329329
ENV PATH /var/lib/kolla/venv/bin:$PATH
330330

331-
RUN {{ macros.install_pip(openstack_base_pip_packages | customizable("pip_packages")) }}
331+
RUN {{ macros.install_pip(['pip', 'wheel', 'setuptools']) }} \
332+
&& {{ macros.install_pip(openstack_base_pip_packages | customizable("pip_packages")) }}
332333

333334
{% endif %}
334335

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
other:
3+
- |
4+
``kolla-toolbox`` and all images derived from ``openstack-base`` one have
5+
basic Python packages (``pip``, ``wheel``, ``setuptools``) upgraded to latest
6+
versions.

0 commit comments

Comments
 (0)