Skip to content

Commit b64e717

Browse files
markgoddardyoctozepto
authored andcommitted
mariadb: Fix repository URLs
The MariaDB project changed the location of the repositories, and the old URLs no longer work. Fix added for stable branches: Wrap version detection for docker module since it can fail for docker >= 6.0. Closes-Bug: #1988121 Change-Id: Ia094cd1e29232c47d1fb26e00de569677bc5b8a1 (cherry picked from commit 94fad9f) (cherry picked from commit b3e7221)
1 parent a7b00b0 commit b64e717

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

kolla/image/build.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,9 +332,14 @@ def push_image(self, image):
332332

333333
# Since docker 3.0.0, the argument of 'insecure_registry' is removed.
334334
# To be compatible, set 'insecure_registry=True' for old releases.
335-
dc_running_ver = StrictVersion(docker.version)
336-
if dc_running_ver < StrictVersion('3.0.0'):
337-
kwargs['insecure_registry'] = True
335+
# NOTE(frickler): The version check will fail for docker >= 6.0, but
336+
# in that case we know that the workaround isn't needed.
337+
try:
338+
dc_running_ver = StrictVersion(docker.version)
339+
if dc_running_ver < StrictVersion('3.0.0'):
340+
kwargs['insecure_registry'] = True
341+
except TypeError:
342+
pass
338343

339344
for response in self.dc.push(image.canonical_name, **kwargs):
340345
if 'stream' in response:

kolla/template/repos.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ debian:
6464
influxdb: "deb https://repos.influxdata.com/debian bullseye stable"
6565
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
6666
kibana: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
67-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/debian bullseye main"
67+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/debian bullseye main"
6868
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian bullseye main"
6969
td-agent: "deb http://packages.treasuredata.com/4/debian/bullseye bullseye contrib"
7070

@@ -75,7 +75,7 @@ debian-aarch64:
7575
influxdb: "deb https://repos.influxdata.com/debian bullseye stable"
7676
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
7777
kibana: "deb [arch=amd64] https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
78-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.5/repo/debian bullseye main"
78+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.5/repo/debian bullseye main"
7979
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/debian bullseye main"
8080
td-agent: "deb http://packages.treasuredata.com/4/debian/bullseye bullseye contrib"
8181

@@ -86,7 +86,7 @@ ubuntu:
8686
influxdb: "deb https://repos.influxdata.com/ubuntu focal stable"
8787
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
8888
kibana: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
89-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/ubuntu focal main"
89+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/ubuntu focal main"
9090
qdrouterd: "deb http://ppa.launchpad.net/qpid/released/ubuntu/ focal main"
9191
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu focal main"
9292
td-agent: "deb http://packages.treasuredata.com/4/ubuntu/focal/ focal contrib"
@@ -97,7 +97,7 @@ ubuntu-aarch64:
9797
grafana: "deb https://packages.grafana.com/oss/deb stable main"
9898
influxdb: "deb https://repos.influxdata.com/ubuntu focal stable"
9999
logstash: "deb https://artifacts.elastic.co/packages/oss-7.x/apt stable main"
100-
mariadb: "deb http://downloads.mariadb.com/MariaDB/mariadb-10.3/repo/ubuntu focal main"
100+
mariadb: "deb https://dlm.mariadb.com/repo/mariadb-server/10.3/repo/ubuntu focal main"
101101
rabbitmq: "deb https://dl.cloudsmith.io/public/rabbitmq/rabbitmq-server/deb/ubuntu focal main"
102102
td-agent: "deb http://packages.treasuredata.com/4/ubuntu/focal/ focal contrib"
103103

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
Fixes problems when running with docker-py >=6.
5+
`LP#1988121 <https://launchpad.net/bugs/1988121>`__

0 commit comments

Comments
 (0)