Skip to content

Commit 41335b8

Browse files
author
Matt Pryor
committed
Remove the unneeded RBAC resources from tests
1 parent 975eb46 commit 41335b8

File tree

13 files changed

+117
-64
lines changed

13 files changed

+117
-64
lines changed

chart/templates/clusterrole.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,6 @@ rules:
6565
- jobs
6666
verbs:
6767
- "*"
68-
- apiGroups:
69-
- "rbac.authorization.k8s.io"
70-
resources:
71-
- serviceaccounts
72-
- roles
73-
- rolebindings
74-
verbs:
75-
- "*"
7668
- apiGroups:
7769
- ""
7870
resources:

examples/macvlan/iperf-set.yaml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
apiVersion: perftest.stackhpc.com/v1alpha1
2+
kind: BenchmarkSet
3+
metadata:
4+
name: iperf-macvlan
5+
spec:
6+
template:
7+
apiVersion: perftest.stackhpc.com/v1alpha1
8+
kind: IPerf
9+
spec:
10+
imagePullPolicy: Always
11+
hostNetwork: false
12+
networkName: default/shared-network
13+
resources:
14+
limits:
15+
rdma/rdma_shared_device_a: 1
16+
duration: 30
17+
permutations:
18+
product:
19+
streams: [1, 2, 4, 8, 16, 32, 64, 80, 128]
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
apiVersion: perftest.stackhpc.com/v1alpha1
2+
kind: BenchmarkSet
3+
metadata:
4+
name: mpi-pingpong-macvlan
5+
spec:
6+
template:
7+
apiVersion: perftest.stackhpc.com/v1alpha1
8+
kind: MPIPingPong
9+
spec:
10+
imagePullPolicy: Always
11+
hostNetwork: false
12+
networkName: default/shared-network
13+
resources:
14+
limits:
15+
rdma/rdma_shared_device_a: 1
16+
permutations:
17+
product:
18+
transport: [TCP, RDMA]

examples/macvlan/openfoam-set.yaml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
apiVersion: perftest.stackhpc.com/v1alpha1
2+
kind: BenchmarkSet
3+
metadata:
4+
name: openfoam-macvlan
5+
spec:
6+
template:
7+
apiVersion: perftest.stackhpc.com/v1alpha1
8+
kind: OpenFOAM
9+
spec:
10+
imagePullPolicy: Always
11+
hostNetwork: false
12+
networkName: default/shared-network
13+
resources:
14+
limits:
15+
rdma/rdma_shared_device_a: 1
16+
problemSize: S
17+
numProcs: 48
18+
permutations:
19+
product:
20+
transport: [TCP, RDMA]
21+
numNodes: [2, 4, 8, 12]

examples/macvlan/rdma-bw-set.yaml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
apiVersion: perftest.stackhpc.com/v1alpha1
2+
kind: BenchmarkSet
3+
metadata:
4+
name: rdma-bandwidth-macvlan
5+
spec:
6+
template:
7+
apiVersion: perftest.stackhpc.com/v1alpha1
8+
kind: RDMABandwidth
9+
spec:
10+
imagePullPolicy: Always
11+
hostNetwork: false
12+
networkName: default/shared-network
13+
resources:
14+
limits:
15+
rdma/rdma_shared_device_a: 1
16+
qps: 512
17+
iterations: 25
18+
extraArgs:
19+
- --tclass=96
20+
permutations:
21+
product:
22+
mode: [read, write]
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
apiVersion: perftest.stackhpc.com/v1alpha1
2+
kind: RDMABandwidth
3+
metadata:
4+
generateName: rdma-bandwidth-macvlan-
5+
spec:
6+
imagePullPolicy: Always
7+
hostNetwork: false
8+
networkName: default/shared-network
9+
resources:
10+
limits:
11+
rdma/rdma_shared_device_a: 1
12+
mode: write
13+
qps: 512
14+
iterations: 25
15+
extraArgs:
16+
- --tclass=96

examples/macvlan/rdma-lat-set.yaml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
apiVersion: perftest.stackhpc.com/v1alpha1
2+
kind: BenchmarkSet
3+
metadata:
4+
name: rdma-latency-macvlan
5+
spec:
6+
template:
7+
apiVersion: perftest.stackhpc.com/v1alpha1
8+
kind: RDMALatency
9+
spec:
10+
imagePullPolicy: Always
11+
hostNetwork: false
12+
networkName: default/shared-network
13+
resources:
14+
limits:
15+
rdma/rdma_shared_device_a: 1
16+
iterations: 1000
17+
extraArgs:
18+
- --tclass=96
19+
permutations:
20+
product:
21+
mode: [read, write]

python/perftest/templates/_macros.j2

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -7,47 +7,6 @@
77
{%- endif %}
88
{%- endmacro %}
99

10-
{% macro discovery_rbac(benchmark) -%}
11-
---
12-
apiVersion: v1
13-
kind: ServiceAccount
14-
metadata:
15-
name: {{ benchmark.metadata.name }}
16-
labels:
17-
{{ labels(benchmark) | indent(4) }}
18-
---
19-
apiVersion: rbac.authorization.k8s.io/v1
20-
kind: Role
21-
metadata:
22-
name: {{ benchmark.metadata.name }}-discovery
23-
labels:
24-
{{ labels(benchmark) | indent(4) }}
25-
rules:
26-
# We just need to be able to read the discovery configmap
27-
- apiGroups:
28-
- ""
29-
resources:
30-
- configmaps
31-
resourceNames:
32-
- {{ benchmark.metadata.name }}-hosts
33-
verbs:
34-
- get
35-
---
36-
apiVersion: rbac.authorization.k8s.io/v1
37-
kind: RoleBinding
38-
metadata:
39-
name: {{ benchmark.metadata.name }}-discovery
40-
labels:
41-
{{ labels(benchmark) | indent(4) }}
42-
subjects:
43-
- kind: ServiceAccount
44-
name: {{ benchmark.metadata.name }}
45-
roleRef:
46-
apiGroup: rbac.authorization.k8s.io
47-
kind: Role
48-
name: {{ benchmark.metadata.name }}-discovery
49-
{%- endmacro %}
50-
5110
{% macro discovery_service(benchmark) -%}
5211
apiVersion: v1
5312
kind: Service

python/perftest/templates/iperf.yaml.j2

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{% import '_macros.j2' as macros %}
22

3-
{{ macros.discovery_rbac(benchmark) }}
43
---
54
{{ macros.discovery_service(benchmark) }}
65
---
@@ -21,7 +20,6 @@ tasks:
2120
{%- endif %}
2221
spec:
2322
priorityClassName: {{ benchmark.status.priority_class_name }}
24-
serviceAccountName: {{ benchmark.metadata.name }}
2523
{%- if benchmark.spec.host_network %}
2624
hostNetwork: true
2725
dnsPolicy: ClusterFirstWithHostNet
@@ -69,7 +67,6 @@ tasks:
6967
{%- endif %}
7068
spec:
7169
priorityClassName: {{ benchmark.status.priority_class_name }}
72-
serviceAccountName: {{ benchmark.metadata.name }}
7370
{%- if benchmark.spec.host_network %}
7471
hostNetwork: true
7572
dnsPolicy: ClusterFirstWithHostNet

python/perftest/templates/mpipingpong.yaml.j2

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{% import '_macros.j2' as macros %}
22

3-
{{ macros.discovery_rbac(benchmark) }}
43
---
54
{{ macros.discovery_service(benchmark) }}
65
---
@@ -30,7 +29,6 @@ tasks:
3029
{%- endif %}
3130
spec:
3231
priorityClassName: {{ benchmark.status.priority_class_name }}
33-
serviceAccountName: {{ benchmark.metadata.name }}
3432
{%- if benchmark.spec.host_network %}
3533
hostNetwork: true
3634
dnsPolicy: ClusterFirstWithHostNet
@@ -109,7 +107,6 @@ tasks:
109107
{%- endif %}
110108
spec:
111109
priorityClassName: {{ benchmark.status.priority_class_name }}
112-
serviceAccountName: {{ benchmark.metadata.name }}
113110
{%- if benchmark.spec.host_network %}
114111
hostNetwork: true
115112
dnsPolicy: ClusterFirstWithHostNet

0 commit comments

Comments
 (0)