Skip to content

Commit 312aa6a

Browse files
lujiefsiwaipeng
authored andcommitted
Move the chmod function before the write and flush functions to prevent sensitive information leakage.
Closes-Bug: #2047690 Change-Id: I2b88a14cc67a4fba35fcfc187a91771e1d714844 (cherry picked from commit cb71d19) (cherry picked from commit 272fd68) (cherry picked from commit 883b40b) (cherry picked from commit e79907c)
1 parent df2bcab commit 312aa6a

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

magnum/conductor/handlers/common/cert_manager.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,23 +189,22 @@ def create_client_files(cluster, context=None):
189189
magnum_cert = get_cluster_magnum_cert(cluster, context)
190190

191191
ca_file = open(cached_ca_file, "w+")
192+
os.chmod(cached_ca_file, 0o600)
192193
ca_file.write(encodeutils.safe_decode(ca_cert.get_certificate()))
193194
ca_file.flush()
194195

195196
key_file = open(cached_key_file, "w+")
197+
os.chmod(cached_key_file, 0o600)
196198
key_file.write(encodeutils.safe_decode(
197199
magnum_cert.get_decrypted_private_key()))
198200
key_file.flush()
199201

200202
cert_file = open(cached_cert_file, "w+")
203+
os.chmod(cached_cert_file, 0o600)
201204
cert_file.write(
202205
encodeutils.safe_decode(magnum_cert.get_certificate()))
203206
cert_file.flush()
204207

205-
os.chmod(cached_ca_file, 0o600)
206-
os.chmod(cached_key_file, 0o600)
207-
os.chmod(cached_cert_file, 0o600)
208-
209208
else:
210209
ca_file = open(cached_ca_file, "r")
211210
key_file = open(cached_key_file, "r")

0 commit comments

Comments
 (0)