[FT] Wait for the FIP Port_Binding event before checking MAC removal

In the test ``test_floatingip_mac_bindings``, when a FIP is created, the
FIP address "MAC_Binding" register should be removed. This patch is
adding an active wait for the FIP address "Port_Binding" before checking
the "MAC_Binding" removal.

This patch is also increasing the timeout to check the "MAC_Binding"
removal, from 15 to 30 seconds. This excesive delay could be caused
because of how the event ``run`` method is handled. Once the eventlet
removal is finished, we should revert this timeout increase.

Conflicts:
  neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py

Closes-Bug: #2115242
Signed-off-by: Rodolfo Alonso Hernandez <[email protected]>
Change-Id: Ia153b48aaec72e6a073b313ef2aea8efac6dbbae
(cherry picked from commit 5034b07)

Author: ralonsoh

neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py

@@ -69,6 +69,22 @@ def __init__(self, chassis_name):
         super().__init__(events, 'Chassis_Private', conditions, timeout=15)
 
 
+class WaitForPortBindingFIPEvent(event.WaitEvent):
+    event_name = 'WaitForPortBindingFIPEvent'
+
+    def __init__(self, fip):
+        events = (self.ROW_UPDATE, )
+        self._fip = fip
+        super().__init__(events, 'Port_Binding', {}, timeout=15)
+
+    def match_fn(self, event, row, old=None):
+        try:
+            return (row.external_ids[ovn_const.OVN_PORT_FIP_EXT_ID_KEY] ==
+                    self._fip)
+        except (AttributeError, KeyError):
+            return False
+
+
 class DistributedLockTestEvent(event.WaitEvent):
     ONETIME = False
     COUNTER = 0
@@ -219,10 +235,15 @@ def test_floatingip_mac_bindings(self):
         port = self.create_port()
 
         # Ensure that the MAC_Binding entry gets deleted after creating a FIP
+        fip_event = WaitForPortBindingFIPEvent('100.0.0.21')
+        self.mech_driver.sb_ovn.idl.notify_handler.watch_event(fip_event)
         fip = self._create_fip(port, '100.0.0.21')
+        self.assertTrue(fip_event.wait())
+        # TODO(ralonsoh): restore the timeout=15 value (or even lower) once
+        # the eventlet removal finishes.
         n_utils.wait_until_true(
             lambda: not self._check_mac_binding_exists(macb_id),
-            timeout=15, sleep=1)
+            timeout=30, sleep=1)
 
         # Now that the FIP is created, add a new MAC_Binding entry with the
         # same IP address
@@ -231,9 +252,11 @@ def test_floatingip_mac_bindings(self):
 
         # Ensure that the MAC_Binding entry gets deleted after deleting the FIP
         self.l3_plugin.delete_floatingip(self.context, fip['id'])
+        # TODO(ralonsoh): restore the timeout=15 value (or even lower) once
+        # the eventlet removal finishes.
         n_utils.wait_until_true(
             lambda: not self._check_mac_binding_exists(macb_id),
-            timeout=15, sleep=1)
+            timeout=30, sleep=1)
 
     def _test_port_binding_and_status(self, port_id, action, status):
         # This function binds or unbinds port to chassis and