Revert "Add sleep before checking if ovs port is in the namespace"

This reverts commit f4e0b02.

Reason for revert:
This patch seems to be breaking the test
"test_multiple_agents_for_network(Open vSwitch agent)" in the
fullstack job.

Related-Bug: #1961740

Change-Id: Ia8764965b54e68f04864ef2ddd04f3d966af55ec

Author: ralonsoh

neutron/agent/linux/interface.py

@@ -356,7 +356,7 @@ def _add_device_to_namespace(self, ip_wrapper, device, namespace):
         namespace_obj = ip_wrapper.ensure_namespace(namespace)
         for i in range(9):
             try:
-                namespace_obj.add_device_to_namespace(device, is_ovs_port=True)
+                namespace_obj.add_device_to_namespace(device)
                 break
             except ip_lib.NetworkInterfaceNotFound:
                 # NOTE(slaweq): if the exception was NetworkInterfaceNotFound

neutron/agent/linux/ip_lib.py

@@ -270,9 +270,9 @@ def garbage_collect_namespace(self):
                 return True
         return False
 
-    def add_device_to_namespace(self, device, is_ovs_port=False):
+    def add_device_to_namespace(self, device):
         if self.namespace:
-            device.link.set_netns(self.namespace, is_ovs_port=is_ovs_port)
+            device.link.set_netns(self.namespace)
 
     def add_vlan(self, name, physical_interface, vlan_id):
         privileged.create_interface(name,
@@ -462,15 +462,10 @@ def set_down(self):
         privileged.set_link_attribute(
             self.name, self._parent.namespace, state='down')
 
-    def set_netns(self, namespace, is_ovs_port=False):
+    def set_netns(self, namespace):
         privileged.set_link_attribute(
             self.name, self._parent.namespace, net_ns_fd=namespace)
         self._parent.namespace = namespace
-        if is_ovs_port:
-            # NOTE(slaweq): because of the "shy port" which may dissapear for
-            # short time after it's moved to the namespace we need to wait
-            # a bit before checking if port really exists in the namespace
-            time.sleep(1)
         common_utils.wait_until_true(lambda: self.exists, timeout=5,
                                      sleep=0.5)
 

neutron/tests/unit/agent/linux/test_interface.py

@@ -468,11 +468,11 @@ def device_exists(dev, namespace=None):
                 expected.extend(
                     [mock.call().ensure_namespace(namespace),
                      mock.call().ensure_namespace().add_device_to_namespace(
-                         mock.ANY, is_ovs_port=True),
+                         mock.ANY),
                      mock.call().ensure_namespace().add_device_to_namespace(
-                         mock.ANY, is_ovs_port=True),
+                         mock.ANY),
                      mock.call().ensure_namespace().add_device_to_namespace(
-                         mock.ANY, is_ovs_port=True)])
+                         mock.ANY)])
             expected.extend([
                 mock.call(namespace=namespace),
                 mock.call().device('tap0'),

neutron/tests/unit/agent/linux/test_ip_lib.py

@@ -506,8 +506,7 @@ def fake_create_interface(ifname, namespace, kind, **kwargs):
     def test_add_device_to_namespace(self):
         dev = mock.Mock()
         ip_lib.IPWrapper(namespace='ns').add_device_to_namespace(dev)
-        dev.assert_has_calls(
-            [mock.call.link.set_netns('ns', is_ovs_port=False)])
+        dev.assert_has_calls([mock.call.link.set_netns('ns')])
 
     def test_add_device_to_namespace_is_none(self):
         dev = mock.Mock()