Skip to content

Commit 4a7e7f2

Browse files
elajkatkarelyatin
authored andcommitted
Functional: assert multiple calls for update_virtual_port_host
test_virtual_port_host_update assumed update_virtual_port_host to be called once, but the test started to fail when [1] was merged and OVN version was bumped to v22.03.3 (not yet released). PortBindingUpdateVirtualPortsEvent with event ROW_DELETE received twice in the failing case. Backport Note: It's required since [2] merged, ovn version deployed is not related to the failure. [1]: https://review.opendev.org/c/openstack/neutron/+/880890 [2]: https://review.opendev.org/q/I34caf7d0212ccb4bd7259c4414e7c3994bd8da4d Closes-bug: #2023634 Change-Id: I0ac92e3692fb1ba9667fee2f6fbf531a57b7b5b8 (cherry picked from commit 5932785)
1 parent efa5bc5 commit 4a7e7f2

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,11 @@ def test_virtual_port_host_update(self, mock_update_vip_host):
399399
n_utils.wait_until_true(lambda: mock_update_vip_host.called,
400400
timeout=10)
401401
# The virtual port is deleted and so the associated "Port_Binding".
402-
mock_update_vip_host.assert_called_once_with(vip['id'], None)
402+
# With OVN v22.03.3 sometimes 2 delete events are received with the
403+
# same arguments.
404+
# TODO(lajoskatona): check when new OVN version is out
405+
# if this behaviour is changed.
406+
mock_update_vip_host.assert_called_with(vip['id'], None)
403407

404408

405409
class TestNBDbMonitorOverTcp(TestNBDbMonitor):

0 commit comments

Comments
 (0)