[stable only] Do not fail on missing logical router ports

set_gateway_mtu runs for all the gateway ports for a network
and if one of the ports get's deleted in meanwhile
whole transaction fails.

To handle this we need to add if_exists=True to the transaction
but for that it needs to be supported in ovsdbapp. It's fixed
in ovsdbapp with [1] but would require to bump ovsdbapp
minimal version in requirements.txt which we normally don't
do for stable branches.

So using "update_lrouter_port" instead as that have the
required option available. Before [2] that was only used
but during the switch if_exists part was missed.

[1] https://review.opendev.org/q/I56685478214aae7b6d3a2a3187297ad4eb1869a3
[2] https://review.opendev.org/c/openstack/neutron/+/762695

Closes-Bug: #2065701
Related-Bug: #2060163
Change-Id: I447990509cdea9830228d3bc92a97062cc57a472

Author: karelyatin

neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py

@@ -2058,7 +2058,8 @@ def set_gateway_mtu(self, context, prov_net, txn=None):
         for port in ports:
             lrp_name = utils.ovn_lrouter_port_name(port['id'])
             options = self._gen_router_port_options(port, prov_net)
-            commands.append(self._nb_idl.lrp_set_options(lrp_name, **options))
+            commands.append(self._nb_idl.update_lrouter_port(
+                lrp_name, if_exists=True, **options))
         self._transaction(commands, txn=txn)
 
     def _check_network_changes_in_ha_chassis_groups(self,

neutron/tests/unit/fake_resources.py

@@ -63,7 +63,6 @@ def __init__(self, **kwargs):
         self.delete_lswitch_port = mock.Mock()
         self.get_acls_for_lswitches = mock.Mock()
         self.lrp_del = mock.Mock()
-        self.lrp_set_options = mock.Mock()
         self.lr_add = mock.Mock()
         self.update_lrouter = mock.Mock()
         self.lr_del = mock.Mock()

neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

@@ -2573,8 +2573,8 @@ def _test_update_network_fragmentation(self, new_mtu, expected_opts, grps,
                 self.mech_driver.update_network_postcommit(fake_ctx)
 
                 lrp_name = ovn_utils.ovn_lrouter_port_name(port['port']['id'])
-                self.nb_ovn.lrp_set_options.assert_called_once_with(
-                    lrp_name, **expected_opts)
+                self.nb_ovn.update_lrouter_port.assert_called_once_with(
+                    lrp_name, if_exists=True, **expected_opts)
 
     def test_update_network_need_to_frag_enabled(self):
         ovn_conf.cfg.CONF.set_override('ovn_emit_need_to_frag', True,

neutron/tests/unit/services/ovn_l3/test_plugin.py

@@ -1987,7 +1987,7 @@ def test_add_router_interface_need_to_frag_enabled_then_remove(
         self.l3_inst._nb_ovn.add_lrouter_port.assert_called_once_with(
             **fake_router_port_assert)
         # Since if_exists = True it will safely return
-        self.l3_inst._nb_ovn.lrp_set_options(
+        self.l3_inst._nb_ovn.update_lrouter_port(
             name='lrp-router-port-id', if_exists=True,
             options=fake_router_port_assert)
         # If no if_exists is provided, it is defaulted to true, so this