Fix LoopingCallBase argument issue

I changed the argument order for LoopingCallBase based
on a pep8 failure, but it led to the code not working.
Changed caller to correctly specify the argument using
the 'f' keyword to fix the issue.

Closes-bug: #2112492
Change-Id: Iceac2354a669939435c1ed0d32294abc56462f98
Signed-off-by: Brian Haley <[email protected]>

Author: brianphaley

neutron/agent/metadata/agent.py

@@ -296,7 +296,7 @@ def _init_state_reporting(self):
         report_interval = cfg.CONF.AGENT.report_interval
         if report_interval:
             self.heartbeat = loopingcall.FixedIntervalLoopingCall(
-                self._report_state)
+                f=self._report_state)
             self.heartbeat.start(interval=report_interval)
 
     def _report_state(self):

neutron/tests/unit/agent/metadata/test_agent.py

@@ -447,7 +447,7 @@ def test_run(self, ensure_dir, server, handler):
         server.assert_has_calls([
             mock.call('/the/path', mock.ANY),
             mock.call().serve_forever()])
-        self.looping_mock.assert_called_once_with(p._report_state)
+        self.looping_mock.assert_called_once_with(f=p._report_state)
         self.looping_mock.return_value.start.assert_called_once_with(
             interval=mock.ANY)