Merge "[OVN] Check LSP.up status before setting the port host info" into stable/2023.1

Author: Zuul

neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py

@@ -294,7 +294,14 @@ def update_lsp_host_info(self, context, db_port, up=True):
             # NOTE(ralonsoh): OVN subports don't have host ID information.
             return
 
+        port_up = self._nb_idl.lsp_get_up(db_port.id).execute(
+            check_error=True)
         if up:
+            if not port_up:
+                LOG.warning('Logical_Switch_Port %s host information not '
+                            'updated, the port state is down')
+                return
+
             if not db_port.port_bindings:
                 return
 
@@ -316,6 +323,11 @@ def update_lsp_host_info(self, context, db_port, up=True):
                 self._nb_idl.db_set(
                     'Logical_Switch_Port', db_port.id, ext_ids))
         else:
+            if port_up:
+                LOG.warning('Logical_Switch_Port %s host information not '
+                            'removed, the port state is up')
+                return
+
             cmd.append(
                 self._nb_idl.db_remove(
                     'Logical_Switch_Port', db_port.id, 'external_ids',

neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_client.py

@@ -164,6 +164,7 @@ def test_update_lsp_host_info_down(self):
         context = mock.MagicMock()
         port_id = 'fake-port-id'
         db_port = mock.Mock(id=port_id)
+        self.nb_idl.lsp_get_up.return_value.execute.return_value = False
 
         self.ovn_client.update_lsp_host_info(context, db_port, up=False)