Skip to content

Commit f7e9b2e

Browse files
committed
Revert "Use HasStandardAttributes as parent class for Tags DB model"
This reverts commit 85d3fff. Reason for revert: The original change was made as a “cheap win” to optimize the number of queries the neutron server makes during testing. This did improve the number of queries made but introduced regression in real world deployments where some customers(through automation) would define hundreds of tags per port across a large deployment. I am proposing to revert this change in favor of the old “subquery” relation in order to fix this regression. In addition, I filed the Related-Bug #2069061 to investigate using `selectin` as the more appropriate long term solution. Change-Id: I83ec349e49e1f343da8996cab149d76443120873 Closes-bug: #2068761 Related-Bug: #2069061
1 parent 0d8cc09 commit f7e9b2e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

neutron/db/models/tag.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ class Tag(model_base.BASEV2):
2626
tag = sa.Column(sa.String(255), nullable=False, primary_key=True)
2727
standard_attr = orm.relationship(
2828
'StandardAttribute', load_on_pending=True,
29-
backref=orm.backref('tags', lazy='joined', viewonly=True),
29+
backref=orm.backref('tags', lazy='subquery', viewonly=True),
3030
sync_backref=False)
3131
revises_on_change = ('standard_attr', )

0 commit comments

Comments
 (0)