Allow hyphen in cinder catalog_info service-type

The official service type for Cinder according to [0] is
"block-storage", so it should be allowed in the validation regex.

[0] https://specs.openstack.org/openstack/service-types-authority/

Closes-Bug: 2092194
Change-Id: I9a57aa72cc9589cec08b0f8d5797108043747ef6
(cherry picked from commit 2c84000)
(cherry picked from commit 137097d)
(cherry picked from commit acc46c5)
(cherry picked from commit b2ceff2)

Author: osfrickler

nova/conf/cinder.py

@@ -24,7 +24,7 @@
 cinder_opts = [
     cfg.StrOpt('catalog_info',
             default='volumev3::publicURL',
-            regex=r'^\w+:\w*:.*$',
+            regex=r'^[\w-]+:\w*:.*$',
             help="""
 Info to match when looking for cinder in the service catalog.
 

releasenotes/notes/cinder-catalog-info-hyphen-842f02febcfff041.yaml

@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    Nova now allows to use a hyphen in the ``[cinder]catalog_info``
+    service-type field, so in particular the official
+    ``block-storage`` type is now valid.
+    `Bug 2092194 <https://bugs.launchpad.net/nova/+bug/2092194>`_