db: Replace 'insert.inline' parameter with 'Insert.inline()' method

Resolve the following RemovedIn20Warning warning:

  The insert.inline parameter will be removed in SQLAlchemy 2.0.  Please
  use the Insert.inline() method.

Change-Id: Ib5fcb841294b4e20fe085e8603d4132e97be7db9
Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

nova/db/main/api.py

@@ -4216,10 +4216,10 @@ def _get_fk_stmts(metadata, conn, table, column, records):
                 # table insert statements for them and prepend them to the
                 # deque.
                 fk_columns = [c.name for c in fk_table.c]
-                fk_insert = fk_shadow_table.insert(inline=True).from_select(
+                fk_insert = fk_shadow_table.insert().from_select(
                     fk_columns,
                     sql.select(fk_table).where(fk_column.in_(fk_records))
-                )
+                ).inline()
                 inserts.appendleft(fk_insert)
                 # Create main table delete statements and prepend them to the
                 # deque.
@@ -4311,9 +4311,9 @@ def _archive_deleted_rows_for_table(metadata, tablename, max_rows, before,
     # {tablename: extra_rows_archived}
     extras = collections.defaultdict(int)
     if records:
-        insert = shadow_table.insert(inline=True).from_select(
+        insert = shadow_table.insert().from_select(
             columns, sql.select(table).where(column.in_(records))
-        )
+        ).inline()
         delete = table.delete().where(column.in_(records))
         # Walk FK relationships and add insert/delete statements for rows that
         # refer to this table via FK constraints. fk_inserts and fk_deletes

nova/tests/fixtures/nova.py

@@ -895,12 +895,6 @@ def setUp(self):
             message=r'Passing a string to Connection.execute\(\) is .*',
             category=sqla_exc.SADeprecationWarning)
 
-        warnings.filterwarnings(
-            'ignore',
-            module='nova',
-            message=r'The insert.inline parameter will be removed .*',
-            category=sqla_exc.SADeprecationWarning)
-
         warnings.filterwarnings(
             'ignore',
             module='nova',