Merge "Allow deletion of compute service with no compute nodes" into stable/victoria

Author: Zuul

nova/api/openstack/compute/services.py

@@ -267,10 +267,25 @@ def delete(self, req, id):
                 # service delete since we could orphan resource providers and
                 # break the ability to do things like confirm/revert instances
                 # in VERIFY_RESIZE status.
-                compute_nodes = objects.ComputeNodeList.get_all_by_host(
-                    context, service.host)
-                self._assert_no_in_progress_migrations(
-                    context, id, compute_nodes)
+                compute_nodes = []
+                try:
+                    compute_nodes = objects.ComputeNodeList.get_all_by_host(
+                        context, service.host)
+                    self._assert_no_in_progress_migrations(
+                        context, id, compute_nodes)
+                except exception.ComputeHostNotFound:
+                    # NOTE(artom) Consider the following situation:
+                    # - Using the Ironic virt driver
+                    # - Replacing (so removing and re-adding) all baremetal
+                    #   nodes associated with a single nova-compute service
+                    # The update resources periodic will have destroyed the
+                    # compute node records because they're no longer being
+                    # reported by the virt driver. If we then attempt to
+                    # manually delete the compute service record,
+                    # get_all_host() above will raise, as there are no longer
+                    # any compute node records for the host. Catch it here and
+                    # continue to allow compute service deletion.
+                    pass
 
                 aggrs = self.aggregate_api.get_aggregates_by_host(context,
                                                                   service.host)

nova/tests/unit/api/openstack/compute/test_services.py

@@ -712,11 +712,7 @@ def test_services_delete_compute_host_not_found(
                                      'topic': 'compute',
                                      'report_count': 0})
         compute.create()
-        # FIXME(artom) Until bug 1860312 is fixed, the ComputeHostNotFound
-        # error will get bubbled up to the API as an error 500.
-        self.assertRaises(
-            webob.exc.HTTPInternalServerError,
-            self.controller.delete, self.req, compute.id)
+        self.controller.delete(self.req, compute.id)
         mock_get_all_by_host.assert_called_with(
             self.req.environ['nova.context'], 'fake-compute-host')