Merge "libvirt: Stop unconditionally enabling evmcs" into stable/2023.1

Author: Zuul

nova/tests/unit/virt/libvirt/test_driver.py

@@ -27884,7 +27884,10 @@ def test_set_features_windows(self):
         self.assertFalse(hv.reenlightenment)
         self.assertTrue(hv.tlbflush)
         self.assertTrue(hv.ipi)
-        self.assertTrue(hv.evmcs)
+        # NOTE(artom) evmcs only works on Intel hosts, so we can't enable it
+        # unconditionally. Until we become smarter about it, just don't enable
+        # it at all. See bug 2009280.
+        self.assertFalse(hv.evmcs)
 
 
 class LibvirtVolumeUsageTestCase(test.NoDBTestCase):

nova/virt/libvirt/driver.py

@@ -6193,7 +6193,6 @@ def _set_features(self, guest, os_type, image_meta, flavor):
             hv.frequencies = True
             hv.tlbflush = True
             hv.ipi = True
-            hv.evmcs = True
 
             # NOTE(kosamara): Spoofing the vendor_id aims to allow the nvidia
             # driver to work on windows VMs. At the moment, the nvidia driver

releasenotes/notes/libvirt-enlightenments-stop-unconditionally-enabling-evmcs-993a825641c4b9f3.yaml

@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    Bug 2009280 has been fixed by no longer enabling the evmcs enlightenment in
+    the libvirt driver. evmcs only works on Intel CPUs, and domains with that
+    enlightenment cannot be started on AMD hosts. There is a possible future
+    feature to enable support for generating this enlightenment only when
+    running on Intel hosts.