Allow for invalid resource provider allocations

Sometimes placement can get in a state where there are invalid resource provider allocations that do not have an associated server instance.

Author: markgoddard

os_capacity/data/server.py

@@ -28,7 +28,10 @@ def _parse_created(raw_created):
 
 def get(compute_client, uuid):
     url = "/servers/%s" % uuid
-    raw_server = compute_client.get(url).json()['server']
+    response = compute_client.get(url)
+    if not response.ok:
+        return None
+    raw_server = response.json()['server']
     return Server(
         uuid=raw_server['id'],
         name=raw_server['name'],

os_capacity/utils.py

@@ -143,13 +143,14 @@ def get_allocations_with_server_info(app, flat_usage=True, get_names=False):
             usage = ", ".join(usage_amounts)
 
         server = server_data.get(app.compute_client, allocation.consumer_uuid)
-        delta = now - server.created
-        days_running = delta.days + 1
-
-        allocation_tuples.append(AllocationList(
-            rp_name, allocation.consumer_uuid, usage,
-            server.flavor_id, days_running, server.project_id,
-            server.user_id))
+        if server:
+            delta = now - server.created
+            days_running = delta.days + 1
+
+            allocation_tuples.append(AllocationList(
+                rp_name, allocation.consumer_uuid, usage,
+                server.flavor_id, days_running, server.project_id,
+                server.user_id))
 
     allocation_tuples.sort(key=lambda x: (x.project_id, x.user_id,
                                           x.days * -1, x.flavor_id))