Skip to content

Commit 0cdc041

Browse files
author
Ihar Hrachyshka
committed
tests: Remove obsolete TODO about a fd leak
The warnings are no longer happening on main. I believe at one point in time, Connection.stop() was mocked out while connection open was not. Not anymore. Change-Id: I87b917f0c4e5d607e37c780d8d3ce12beea6945b
1 parent b0bfda2 commit 0cdc041

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

ovn_octavia_provider/tests/unit/ovsdb/test_impl_idl_ovn.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ class TestOvnNbIdlForLb(base.BaseTestCase):
3636
def setUp(self):
3737
super().setUp()
3838
ovn_config.register_opts()
39-
# TODO(haleyb) - figure out why every test in this class generates
40-
# this warning, think it's in relation to reading this schema file:
41-
# sys:1: ResourceWarning: unclosed file <_io.FileIO name=1 mode='wb'
42-
# closefd=True> ResourceWarning: Enable tracemalloc to get the object
43-
# allocation traceback
4439
self.mock_gsh = mock.patch.object(
4540
idlutils, 'get_schema_helper',
4641
side_effect=lambda x, y: ovs_idl.SchemaHelper(
@@ -100,11 +95,6 @@ class TestOvnSbIdlForLb(base.BaseTestCase):
10095
def setUp(self):
10196
super().setUp()
10297
ovn_config.register_opts()
103-
# TODO(haleyb) - figure out why every test in this class generates
104-
# this warning, think it's in relation to reading this schema file:
105-
# sys:1: ResourceWarning: unclosed file <_io.FileIO name=1 mode='wb'
106-
# closefd=True> ResourceWarning: Enable tracemalloc to get the object
107-
# allocation traceback
10898
self.mock_gsh = mock.patch.object(
10999
idlutils, 'get_schema_helper',
110100
side_effect=lambda x, y: ovs_idl.SchemaHelper(

0 commit comments

Comments
 (0)