fix: collector_duration_seconds metric

Arnaldo Mendonca · Arnaldo Mendonca · commit 0cdfc4a2c07b · 2022-03-06T16:05:52.000-03:00
diff --git a/collector/redfish_collector.go b/collector/redfish_collector.go
@@ -86,13 +86,13 @@ func (r *RedfishCollector) Collect(ch chan<- prometheus.Metric) {
 		wg := &sync.WaitGroup{}
 		wg.Add(len(r.collectors))
 
-		defer wg.Wait()
 		for _, collector := range r.collectors {
 			go func(collector prometheus.Collector) {
 				defer wg.Done()
 				collector.Collect(ch)
 			}(collector)
 		}
+		wg.Wait()
 	} else {
 		r.redfishUp.Set(0)
 	}

Original file line number	Diff line number	Diff line change
`@@ -86,13 +86,13 @@ func (r *RedfishCollector) Collect(ch chan<- prometheus.Metric) {`
`86`	`86`	`wg := &sync.WaitGroup{}`
`87`	`87`	`wg.Add(len(r.collectors))`
`88`	`88`
`89`		`- defer wg.Wait()`
`90`	`89`	`for _, collector := range r.collectors {`
`91`	`90`	`go func(collector prometheus.Collector) {`
`92`	`91`	`defer wg.Done()`
`93`	`92`	`collector.Collect(ch)`
`94`	`93`	`}(collector)`
`95`	`94`	`}`
	`95`	`+ wg.Wait()`
`96`	`96`	`} else {`
`97`	`97`	`r.redfishUp.Set(0)`
`98`	`98`	`}`