fix: remove redundant formatting

Author: xflipped

collector/chassis_collector.go

@@ -227,7 +227,7 @@ func (c *ChassisCollector) Collect(ch chan<- prometheus.Metric) {
 			physicalSecurity := chassis.PhysicalSecurity
 			if physicalSecurity != (redfish.PhysicalSecurity{}) {
 				physicalSecurityIntrusionSensor := physicalSecurity.IntrusionSensor
-				physicalSecurityIntrusionSensorNumber := fmt.Sprintf("%d", physicalSecurity.IntrusionSensorNumber)
+				physicalSecurityIntrusionSensorNumber := fmt.Sprint(physicalSecurity.IntrusionSensorNumber)
 				physicalSecurityIntrusionSensorReArmMethod := string(physicalSecurity.IntrusionSensorReArm)
 
 				if phySecIntrusionSensor, ok := parsePhySecIntrusionSensor(physicalSecurityIntrusionSensor); ok {

collector/common_collector.go

@@ -37,7 +37,7 @@ func parseLogService(ch chan<- prometheus.Metric, metrics map[string]Metric, sub
 	defer wg.Done()
 	logServiceName := logService.Name
 	logServiceID := logService.ID
-	logServiceEnabled := fmt.Sprintf("%t", logService.ServiceEnabled)
+	logServiceEnabled := fmt.Sprint(logService.ServiceEnabled)
 	logServiceOverWritePolicy := string(logService.OverWritePolicy)
 	logServiceState := logService.Status.State
 	logServiceHealthState := logService.Status.Health
@@ -70,7 +70,7 @@ func parseLogEntry(ch chan<- prometheus.Metric, desc *prometheus.Desc, collector
 	logEntryCode := string(logEntry.EntryCode)
 	logEntryType := string(logEntry.EntryType)
 	logEntryMessageID := logEntry.MessageID
-	logEntrySensorNumber := fmt.Sprintf("%d", logEntry.SensorNumber)
+	logEntrySensorNumber := fmt.Sprint(logEntry.SensorNumber)
 	logEntrySensorType := string(logEntry.SensorType)
 	logEntrySeverityState := logEntry.Severity
 

collector/manager_collector.go

@@ -86,7 +86,7 @@ func (m *ManagerCollector) Collect(ch chan<- prometheus.Metric) {
 			ManagerID := manager.ID
 			managerName := manager.Name
 			managerModel := manager.Model
-			managerType := fmt.Sprintf("%v", manager.ManagerType)
+			managerType := fmt.Sprint(manager.ManagerType)
 			managerPowerState := manager.PowerState
 			managerState := manager.Status.State
 			managerHealthState := manager.Status.Health

collector/system_collector.go

@@ -471,7 +471,7 @@ func parsePcieDevice(ch chan<- prometheus.Metric, systemHostName string, pcieDev
 	pcieDeviceState := pcieDevice.Status.State
 	pcieDeviceHealthState := pcieDevice.Status.Health
 	pcieDevicePartNumber := pcieDevice.PartNumber
-	pcieDeviceType := fmt.Sprintf("%v,", pcieDevice.DeviceType)
+	pcieDeviceType := fmt.Sprint(pcieDevice.DeviceType)
 	pcieSerialNumber := pcieDevice.SerialNumber
 	systemPCIeDeviceLabelValues := []string{systemHostName, "pcie_device", pcieDeviceName, pcieDeviceID, pcieDevicePartNumber, pcieDeviceType, pcieSerialNumber}
 
@@ -527,9 +527,9 @@ func parseEthernetInterface(ch chan<- prometheus.Metric, systemHostName string,
 func parsePcieFunction(ch chan<- prometheus.Metric, systemHostName string, pcieFunction *redfish.PCIeFunction, wg *sync.WaitGroup) {
 	defer wg.Done()
 	pcieFunctionName := pcieFunction.Name
-	pcieFunctionID := fmt.Sprintf("%v", pcieFunction.ID)
-	pciFunctionDeviceclass := fmt.Sprintf("%v", pcieFunction.DeviceClass)
-	pciFunctionType := fmt.Sprintf("%v", pcieFunction.FunctionType)
+	pcieFunctionID := fmt.Sprint(pcieFunction.ID)
+	pciFunctionDeviceclass := fmt.Sprint(pcieFunction.DeviceClass)
+	pciFunctionType := fmt.Sprint(pcieFunction.FunctionType)
 	pciFunctionState := pcieFunction.Status.State
 	pciFunctionHealthState := pcieFunction.Status.Health