fix: linter issues

xflipped · xflipped · commit 2b05def759f3 · 2023-03-28T23:53:12.000+03:00
diff --git a/collector/system_collector.go b/collector/system_collector.go
@@ -503,7 +503,7 @@ func parseEthernetInterface(ch chan<- prometheus.Metric, systemHostName string,
 func parsePcieFunction(ch chan<- prometheus.Metric, systemHostName string, pcieFunction *redfish.PCIeFunction, wg *sync.WaitGroup) {
 	defer wg.Done()
 	pcieFunctionName := pcieFunction.Name
-	pcieFunctionID := fmt.Sprint("%v", pcieFunction.ID)
+	pcieFunctionID := fmt.Sprintf("%v", pcieFunction.ID)
 	pciFunctionDeviceclass := fmt.Sprintf("%v", pcieFunction.DeviceClass)
 	pciFunctionType := fmt.Sprintf("%v", pcieFunction.FunctionType)
 	pciFunctionState := pcieFunction.Status.State
diff --git a/main.go b/main.go
@@ -62,7 +62,10 @@ func reloadHandler(configLoggerCtx *alog.Entry) http.HandlerFunc {
 			configLoggerCtx.WithField("operation", "sc.ReloadConfig").Info("config file reloaded")
 
 			w.WriteHeader(http.StatusOK)
-			io.WriteString(w, "Configuration reloaded successfully!")
+			_, err = io.WriteString(w, "Configuration reloaded successfully!")
+			if err != nil {
+				configLoggerCtx.Warn("failed to send configuration reload status message")
+			}
 		} else {
 			http.Error(w, "Only PUT and POST methods are allowed", http.StatusBadRequest)
 		}
@@ -136,7 +139,7 @@ func main() {
 	configLoggerCtx.WithField("operation", "sc.ReloadConfig").Info("config file loaded")
 
 	// load config in background to watch for config changes
-	hup := make(chan os.Signal)
+	hup := make(chan os.Signal, 1)
 	reloadCh = make(chan chan error)
 	signal.Notify(hup, syscall.SIGHUP)
 
@@ -166,6 +169,7 @@ func main() {
 	http.Handle("/metrics", promhttp.Handler())
 
 	http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
+		// nolint
 		w.Write([]byte(`<html>
             <head>
             <title>Redfish Exporter</title>
