Skip to content

Commit 44b7909

Browse files
sd109SkylerMalinowski
authored andcommitted
fix: set non-zero job TTL
With TTL of zero a `helm install --wait --wait-for-jobs` command fails because the job is cleaned up by Kubernetes before Helm has a chance to see the job in a completed state. Signed-off-by: sd109 <[email protected]>
1 parent 5ab857e commit 44b7909

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ All notable changes to this project will be documented in this file.
88

99
### Fixed
1010

11+
- Fixed token job `ttlSecondsAfterFinished` being too low for helm
12+
`--wait-for-jobs`.
13+
1114
### Changed
1215

1316
### Removed

helm/slurm/templates/cluster/token-job.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ metadata:
1111
labels:
1212
{{- include "slurm.token.labels" . | nindent 4 }}
1313
spec:
14-
ttlSecondsAfterFinished: 0
14+
ttlSecondsAfterFinished: 60
1515
template:
1616
metadata:
1717
annotations:

0 commit comments

Comments
 (0)