Sets kolla_docker_registry_insecure to true (#297)

* Sets kolla_docker_registry_insecure to true

We currently don't configure TLS for the the local pulp registry.  This adds the pulp server to the list of insecure-registries, so that we can pull images.

* Remove kolla_docker_registry_insecure override in CI environment

Based on comments in code review.

* Use a better default for kolla_docker_registry_insecure

Hoping this will prevent breakage for people already running pulp with TLS.

(cherry picked from commit 78055cf)

Author: jovial

etc/kayobe/kolla.yml

@@ -85,6 +85,11 @@ kolla_install_type: source
 # Docker namespace to use for Kolla images. Default is 'kolla'.
 kolla_docker_namespace: stackhpc
 
+# Whether docker should be configured to use an insecure registry for Kolla
+# images. Default is false, unless docker_registry_enabled is true and
+# docker_registry_enable_tls is false.
+kolla_docker_registry_insecure: "{{ 'https' not in stackhpc_repo_mirror_url }}"
+
 # Username to use to access a docker registry. Default is not set, in which
 # case the registry will be used without authentication.
 kolla_docker_registry_username: "{{ stackhpc_docker_registry_username }}"