Skip to content

Commit 7c5935b

Browse files
committed
Temporarily remove redfish log collection
This isn't working yet (takes far too long to scrape),let's split it out into a separate patch. Also removed the query lookback delta config, as this was working around the much longer scrape times.
1 parent 110afe4 commit 7c5935b

File tree

5 files changed

+2
-37
lines changed

5 files changed

+2
-37
lines changed

etc/kayobe/kolla/config/prometheus/prometheus.rules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ groups:
77
rules:
88

99
- alert: PrometheusTargetMissing
10-
expr: up{job!="redfish-exporter-seed", job!="redfish-exporter-collectlog"} == 0
10+
expr: up{job!="redfish-exporter-seed"} == 0
1111
for: 5m
1212
labels:
1313
severity: critical

etc/kayobe/kolla/config/prometheus/prometheus.yml.d/60-redfish.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -23,27 +23,5 @@ scrape_configs:
2323
server: '{{ host }}'
2424
env: "{{ kayobe_environment | default('openstack') }}"
2525
group: "{{ hostvars[host]['redfish_exporter_scrape_group'] | default('overcloud') }}"
26-
{% endfor %}
27-
- job_name: redfish-exporter-collectlog
28-
params:
29-
collectlogs: ['true']
30-
metrics_path: /redfish
31-
scrape_timeout: 1200s
32-
scrape_interval: 3600s
33-
relabel_configs:
34-
- source_labels: [__address__]
35-
target_label: __param_target
36-
- source_labels: [__param_target]
37-
target_label: instance
38-
- target_label: __address__
39-
replacement: "{{ lookup('vars', admin_oc_net_name ~ '_ips')[groups.seed.0] }}:9610"
40-
static_configs:
41-
{% for host in groups.get('redfish_exporter_targets', []) %}
42-
- targets:
43-
- '{{ hostvars[host]["redfish_exporter_target_address"] }}'
44-
labels:
45-
server: '{{ host }}'
46-
env: "{{ kayobe_environment | default('openstack') }}"
47-
group: "{{ hostvars[host]['redfish_exporter_scrape_group'] | default('overcloud') }}"
4826
{% endfor %}
4927
{% endif %}

etc/kayobe/kolla/globals.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ kolla_image_tags:
2626
# Monitoring and alerting related settings
2727

2828
opensearch_heap_size: 8g
29-
prometheus_cmdline_extras: "--storage.tsdb.retention.time=30d --query.lookback-delta={{ stackhpc_prometheus_query_lookback_delta }}"
29+
prometheus_cmdline_extras: "--storage.tsdb.retention.time=30d"
3030

3131
# Additional command line flags for node exporter to enable texfile collector for disk metrics and create textfile docker volume
3232
prometheus_node_exporter_extra_volumes:

etc/kayobe/stackhpc-monitoring.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
---
22
# StackHPC monitoring configuration
3-
###############################################################################
4-
# Prometheus server configuration
5-
6-
# How far prometheus will look back in time to find a metric.
7-
stackhpc_prometheus_query_lookback_delta: >-
8-
{{ [stackhpc_redfish_exporter_scrape_interval | int,
9-
stackhpc_os_capacity_scrape_interval | int,
10-
stackhpc_prometheus_openstack_exporter_interval | int,
11-
300] | max + 30 }}s
123

134
###############################################################################
145
# Alert configuration

releasenotes/notes/bumps-redfish-exporter-to-v2-11032fb9dde36283.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ features:
88
``stackhpc_prometheus_openstack_exporter_interval``
99
configuration variables.
1010
fixes:
11-
- |
12-
Sets the prometheus server side option ``query.lookback-delta`` to
13-
the largest scrape interval so that metrics from exporters with large
14-
scrape intervals are not marked stale before the next scrape.
1511
- Fixes various issues with the redfish exporter dashboard.
1612
upgrade:
1713
- |

0 commit comments

Comments
 (0)