Address review comments

Author: assumptionsandg

.github/workflows/package-build-ofed.yml

@@ -189,18 +189,15 @@ jobs:
         run: |
           source venvs/kayobe/bin/activate &&
           source src/kayobe-config/kayobe-env --environment ci-doca-builder &&
-          kayobe playbook run src/kayobe-config/etc/kayobe/ansible/growroot.yml \
-          -e seed_bootstrap_user="cloud-user" \
-          -e controller_bootstrap_user="cloud-user" \
+          kayobe playbook run src/kayobe-config/etc/kayobe/ansible/growroot.yml
         env:
           KAYOBE_VAULT_PASSWORD: ${{ secrets.KAYOBE_VAULT_PASSWORD }}
 
       - name: Configure the seed host (Builder VM)
         run: |
           source venvs/kayobe/bin/activate &&
           source src/kayobe-config/kayobe-env --environment ci-doca-builder &&
-          kayobe seed host configure \
-          --skip-tags network,docker,docker-registry
+          kayobe seed host configure --skip-tags network
         env:
           KAYOBE_VAULT_PASSWORD: ${{ secrets.KAYOBE_VAULT_PASSWORD }}
 

doc/source/contributor/ofed.rst

@@ -54,7 +54,7 @@ Install process
 Release Train configuration
 ---------------------------
 
-The DOCA kernel module repository will need to be synced to the local Pulp service. This can be enabled
+DOCA repositories will need to be synced to the local Pulp service. This can be enabled
 in ``ofed.yml``:
 
 .. code-block:: yaml

etc/kayobe/environments/ci-doca-builder/controllers.yml

@@ -13,7 +13,3 @@ controller_bootstrap_user: cloud-user
 # format.
 controller_lvm_groups:
   - "{{ stackhpc_lvm_group_rootvg }}"
-
-###############################################################################
-# Dummy variable to allow Ansible to accept this file.
-workaround_ansible_issue_8743: yes

etc/kayobe/environments/ci-doca-builder/seed.yml

@@ -15,5 +15,9 @@ seed_lvm_groups:
   - "{{ stackhpc_lvm_group_rootvg }}"
 
 ###############################################################################
-# Dummy variable to allow Ansible to accept this file.
-workaround_ansible_issue_8743: yes
+# Seed node additional containers configuration
+
+# Seed container running a "Pulp in one" service.
+# https://pulpproject.org/pulp-in-one-container/
+# This can be used as a package mirror, and container image registry.
+seed_pulp_container_enabled: false

etc/kayobe/ofed.yml

@@ -8,8 +8,8 @@ stackhpc_pulp_doca_version: 2.9.1
 ###############################################################################
 # Pulp configuration for DOCA OFED
 
-# Whether to sync OFED kernel module packages into the local Pulp service
-stackhpc_pulp_sync_ofed_modules: false
+# Whether to sync OFED repositories into the local Pulp service
+stackhpc_pulp_sync_ofed: false
 
 # DOCA Snapshot versions. The defaults use the appropriate version from
 # pulp-repo-versions.yml

etc/kayobe/pulp.yml

@@ -377,13 +377,13 @@ stackhpc_pulp_rpm_repos:
     url: "{{ stackhpc_release_pulp_content_url }}/doca/{{ stackhpc_pulp_doca_version }}/rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}/x86_64/{{ stackhpc_pulp_repo_rhel9_doca_version }}"
     distribution_name: "doca-{{ stackhpc_pulp_doca_version }}-rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}-"
     base_path: "doca/{{ stackhpc_pulp_doca_version }}/rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}/x86_64/"
-    required: "{{ stackhpc_pulp_sync_el_9 }}"
+    required: "{{ stackhpc_pulp_sync_ofed | bool and stackhpc_pulp_sync_el_9 | bool }}"
 
   - name: OFED Kernel modules for DOCA {{ stackhpc_pulp_doca_version }} - RHEL 9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}
     url: "{{ stackhpc_release_pulp_content_url }}/doca-modules/{{ stackhpc_pulp_doca_version }}/rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}/x86_64/{{ stackhpc_pulp_repo_rhel9_doca_modules_version }}"
     distribution_name: "doca-modules-{{ stackhpc_pulp_doca_version }}-rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}-"
     base_path: "doca-modules/{{ stackhpc_pulp_doca_version }}/rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}/x86_64/"
-    required: "{{ stackhpc_pulp_sync_ofed_modules | bool and stackhpc_pulp_sync_el_9 | bool }}"
+    required: "{{ stackhpc_pulp_sync_ofed | bool and stackhpc_pulp_sync_el_9 | bool }}"
 
 # RPM repositories
 stackhpc_pulp_repository_rpm_repos: >-